* [Qemu-devel] multiple -append?
@ 2017-05-12 14:20 Rob Landley
2017-05-12 22:48 ` Laszlo Ersek
0 siblings, 1 reply; 2+ messages in thread
From: Rob Landley @ 2017-05-12 14:20 UTC (permalink / raw)
To: qemu-devel
When I feed a second -append to qemu-system-i386 they don't get
concatenated, the second replaces the first. Why is it called "append" then?
Rob
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] multiple -append?
2017-05-12 14:20 [Qemu-devel] multiple -append? Rob Landley
@ 2017-05-12 22:48 ` Laszlo Ersek
0 siblings, 0 replies; 2+ messages in thread
From: Laszlo Ersek @ 2017-05-12 22:48 UTC (permalink / raw)
To: Rob Landley, qemu-devel
On 05/12/17 16:20, Rob Landley wrote:
> When I feed a second -append to qemu-system-i386 they don't get
> concatenated, the second replaces the first. Why is it called "append" then?
This behavior dates back to commit a20dd508aa38 ("simplified invocation
- added automatic IDE disk geometry guessing to reuse old disk images
directly", 2003-09-30), which is when "-append" was added.
In said commit, "kernel_cmdline" was *appended* to "params->commandline"
with pstrcat(). The rest is history.
TL;DR: "just because" :)
Thanks
Laszlo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-05-12 22:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-12 14:20 [Qemu-devel] multiple -append? Rob Landley
2017-05-12 22:48 ` Laszlo Ersek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).