* [PATCH v2] arm/translate-a64: fix uninitialized variable warning
@ 2020-01-08 2:39 pannengyuan
2020-01-08 3:43 ` Richard Henderson
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: pannengyuan @ 2020-01-08 2:39 UTC (permalink / raw)
To: peter.maydell
Cc: zhang.zhanghailiang, qemu-trivial, Pan Nengyuan, qemu-devel,
qemu-arm, Euler Robot
From: Pan Nengyuan <pannengyuan@huawei.com>
Fixes:
target/arm/translate-a64.c: In function 'disas_crypto_three_reg_sha512':
target/arm/translate-a64.c:13625:9: error: 'genfn' may be used uninitialized in this function [-Werror=maybe-uninitialized]
genfn(tcg_rd_ptr, tcg_rn_ptr, tcg_rm_ptr);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
qemu/target/arm/translate-a64.c:13609:8: error: 'feature' may be used uninitialized in this function [-Werror=maybe-uninitialized]
if (!feature) {
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com>
---
Changes v2 to v1:
- add a default label to fix uninitialized warnings(suggested by Richard Henderson)
---
target/arm/translate-a64.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c
index d4bebbe629..63a3d26687 100644
--- a/target/arm/translate-a64.c
+++ b/target/arm/translate-a64.c
@@ -13585,6 +13585,8 @@ static void disas_crypto_three_reg_sha512(DisasContext *s, uint32_t insn)
feature = dc_isar_feature(aa64_sha3, s);
genfn = NULL;
break;
+ default:
+ g_assert_not_reached();
}
} else {
switch (opcode) {
--
2.21.0.windows.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] arm/translate-a64: fix uninitialized variable warning
2020-01-08 2:39 [PATCH v2] arm/translate-a64: fix uninitialized variable warning pannengyuan
@ 2020-01-08 3:43 ` Richard Henderson
2020-01-08 10:19 ` Philippe Mathieu-Daudé
2020-01-08 15:10 ` Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Richard Henderson @ 2020-01-08 3:43 UTC (permalink / raw)
To: pannengyuan, peter.maydell
Cc: qemu-trivial, Euler Robot, qemu-arm, zhang.zhanghailiang,
qemu-devel
On 1/8/20 12:39 PM, pannengyuan@huawei.com wrote:
> From: Pan Nengyuan <pannengyuan@huawei.com>
>
> Fixes:
> target/arm/translate-a64.c: In function 'disas_crypto_three_reg_sha512':
> target/arm/translate-a64.c:13625:9: error: 'genfn' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> genfn(tcg_rd_ptr, tcg_rn_ptr, tcg_rm_ptr);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> qemu/target/arm/translate-a64.c:13609:8: error: 'feature' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> if (!feature) {
>
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com>
> ---
> Changes v2 to v1:
> - add a default label to fix uninitialized warnings(suggested by Richard Henderson)
> ---
> target/arm/translate-a64.c | 2 ++
> 1 file changed, 2 insertions(+)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Given that you are using -O2, this should probably also be reported as a GCC bug.
r~
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] arm/translate-a64: fix uninitialized variable warning
2020-01-08 2:39 [PATCH v2] arm/translate-a64: fix uninitialized variable warning pannengyuan
2020-01-08 3:43 ` Richard Henderson
@ 2020-01-08 10:19 ` Philippe Mathieu-Daudé
2020-01-08 15:10 ` Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-01-08 10:19 UTC (permalink / raw)
To: pannengyuan, peter.maydell
Cc: qemu-trivial, Euler Robot, qemu-arm, zhang.zhanghailiang,
qemu-devel
On 1/8/20 3:39 AM, pannengyuan@huawei.com wrote:
> From: Pan Nengyuan <pannengyuan@huawei.com>
>
> Fixes:
> target/arm/translate-a64.c: In function 'disas_crypto_three_reg_sha512':
> target/arm/translate-a64.c:13625:9: error: 'genfn' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> genfn(tcg_rd_ptr, tcg_rn_ptr, tcg_rm_ptr);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> qemu/target/arm/translate-a64.c:13609:8: error: 'feature' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> if (!feature) {
>
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com>
> ---
> Changes v2 to v1:
> - add a default label to fix uninitialized warnings(suggested by Richard Henderson)
> ---
> target/arm/translate-a64.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c
> index d4bebbe629..63a3d26687 100644
> --- a/target/arm/translate-a64.c
> +++ b/target/arm/translate-a64.c
> @@ -13585,6 +13585,8 @@ static void disas_crypto_three_reg_sha512(DisasContext *s, uint32_t insn)
> feature = dc_isar_feature(aa64_sha3, s);
> genfn = NULL;
> break;
> + default:
> + g_assert_not_reached();
> }
> } else {
> switch (opcode) {
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] arm/translate-a64: fix uninitialized variable warning
2020-01-08 2:39 [PATCH v2] arm/translate-a64: fix uninitialized variable warning pannengyuan
2020-01-08 3:43 ` Richard Henderson
2020-01-08 10:19 ` Philippe Mathieu-Daudé
@ 2020-01-08 15:10 ` Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Laurent Vivier @ 2020-01-08 15:10 UTC (permalink / raw)
To: pannengyuan, peter.maydell
Cc: qemu-trivial, Euler Robot, qemu-arm, zhang.zhanghailiang,
qemu-devel
Le 08/01/2020 à 03:39, pannengyuan@huawei.com a écrit :
> From: Pan Nengyuan <pannengyuan@huawei.com>
>
> Fixes:
> target/arm/translate-a64.c: In function 'disas_crypto_three_reg_sha512':
> target/arm/translate-a64.c:13625:9: error: 'genfn' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> genfn(tcg_rd_ptr, tcg_rn_ptr, tcg_rm_ptr);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> qemu/target/arm/translate-a64.c:13609:8: error: 'feature' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> if (!feature) {
>
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com>
> ---
> Changes v2 to v1:
> - add a default label to fix uninitialized warnings(suggested by Richard Henderson)
> ---
> target/arm/translate-a64.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c
> index d4bebbe629..63a3d26687 100644
> --- a/target/arm/translate-a64.c
> +++ b/target/arm/translate-a64.c
> @@ -13585,6 +13585,8 @@ static void disas_crypto_three_reg_sha512(DisasContext *s, uint32_t insn)
> feature = dc_isar_feature(aa64_sha3, s);
> genfn = NULL;
> break;
> + default:
> + g_assert_not_reached();
> }
> } else {
> switch (opcode) {
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-01-08 15:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-08 2:39 [PATCH v2] arm/translate-a64: fix uninitialized variable warning pannengyuan
2020-01-08 3:43 ` Richard Henderson
2020-01-08 10:19 ` Philippe Mathieu-Daudé
2020-01-08 15:10 ` Laurent Vivier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).