From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF6CFC388F9 for ; Wed, 21 Oct 2020 17:28:55 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C5D192224E for ; Wed, 21 Oct 2020 17:28:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="DcCILGa5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C5D192224E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53888 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kVHuv-00011Z-I3 for qemu-devel@archiver.kernel.org; Wed, 21 Oct 2020 13:28:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48938) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kVHtw-0000Fl-GH for qemu-devel@nongnu.org; Wed, 21 Oct 2020 13:27:52 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:20502) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kVHtu-0005BX-2V for qemu-devel@nongnu.org; Wed, 21 Oct 2020 13:27:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603301269; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5xcap34y+NGIi1iQ1S2FgAUFM5Hm/kYTh4ps+8+OrrM=; b=DcCILGa5tuxCyDTzSXMjD7KVD6hC85ferhfomZm0pRVMr6M2JXj9tg5SNuFFsAnS6En+Ox 0egfksLFPNMnfHrjOCeJLaGSwiQ1zb8F1CSlduUT2HyrFmE8nzQmP1qh4Hwv3MYKZpFt8W /ZXPgAL6wGhCi6R2aENMp83ePdb7sx4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-371-9eDFiye2NX-0_FVe_MsdCQ-1; Wed, 21 Oct 2020 13:27:46 -0400 X-MC-Unique: 9eDFiye2NX-0_FVe_MsdCQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5DEBA1074661; Wed, 21 Oct 2020 17:27:45 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-20.ams2.redhat.com [10.36.114.20]) by smtp.corp.redhat.com (Postfix) with ESMTP id A1D1960CCC; Wed, 21 Oct 2020 17:27:35 +0000 (UTC) Subject: Re: roms/efirom, tests/uefi-test-tools: update edk2's own submodules first To: =?UTF-8?Q?Daniel_P._Berrang=c3=a9?= References: <20201020091605.GA2301@aepfle.de> <3fc07eb7-f99a-516b-9bb9-e48049547928@redhat.com> <20201020094419.GF287149@redhat.com> <0e196d48-6735-5116-ade5-a9b138020aea@redhat.com> <46f7af9f-4a18-4352-dad2-cc176ed890e1@redhat.com> <20201021134634.GN412988@redhat.com> From: Laszlo Ersek Message-ID: Date: Wed, 21 Oct 2020 19:27:35 +0200 MIME-Version: 1.0 In-Reply-To: <20201021134634.GN412988@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=lersek@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/21 02:16:02 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Olaf Hering , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org, =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 10/21/20 15:46, Daniel P. Berrangé wrote: > On Wed, Oct 21, 2020 at 02:05:18PM +0200, Laszlo Ersek wrote: >> On 10/20/20 11:54, Philippe Mathieu-Daudé wrote: >>> On 10/20/20 11:44 AM, Daniel P. Berrangé wrote: >>>> On Tue, Oct 20, 2020 at 11:29:01AM +0200, Philippe Mathieu-Daudé wrote: >>>>> Hi Olaf, >>>>> >>>>> On 10/20/20 11:16 AM, Olaf Hering wrote: >>>>>> This is about qemu.git#ec87b5daca761039bbcf781eedbe4987f790836f >>>>>> >>>>>> On Mon, Sep 07, Laszlo Ersek wrote: >>>>>> >>>>>>> In edk2 commit 06033f5abad3 ("BaseTools: Make brotli a submodule", >>>>>>> 2020-04-16), part of edk2-stable202005, the Brotli compressor / >>>>>>> decompressor source code that edk2 had flattened into BaseTools was >>>>>>> replaced with a git submodule. >>>>>>> >>>>>>> This means we have to initialize edk2's own submodules before building >>>>>>> BaseTools not just in "roms/Makefile.edk2", but in "roms/Makefile" >>>>>>> (for >>>>>>> the sake of the "efirom" target) and >>>>>>> "tests/uefi-test-tools/Makefile" as >>>>>>> well. >>>>>> >>>>>>> +++ b/roms/Makefile >>>>>>>    edk2-basetools: >>>>>>> +    cd edk2/BaseTools && git submodule update --init --force >>>>>>>    build-edk2-tools: >>>>>>> +    cd $(edk2_dir)/BaseTools && git submodule update --init --force >>>>>> >>>>>> >>>>>> This change can not possibly be correct. >>>>>> >>>>>> With current qemu.git#master one is forced to have network access to >>>>>> build the roms. This fails with exported (and complete) sources in an >>>>>> offline environment. >>>>> >>>>> The EDK2 roms are only used for testing, we certainly don't want them >>>>> to be used by distributions. I suppose the question is "why is this >>>>> rule called if tests are not built?". >>>> >>>> I don't believe that is correct - the pc-bios/edk*  ROMs and the >>>> corresponding  pc-bios/descriptor files are there for real world >>>> end user consumption.   roms/edk2 should (must) match / reflect >>>> the content used to build the pci-bios/edk* blobs. >>>> >>>> Many distros have a policy requiring them to build everything >>>> from source, so they will ignore the pre-built edk2 ROMs, but >>>> regular end users taking QEMU directly from upstream can certainly >>>> use our edk2 ROMs. >>> >>> Well I'm lost (and I don't think mainstream QEMU have the >>> bandwidth to follow mainstream EDK2 security fixes) so I'm >>> giving up, waiting for clarification from Laszlo. >> >> I definitely don't have time for keeping the edk2 blobs bundled with >> QEMU fresh wrt. security fixes in upstream edk2, so anyone expecting >> that is in for a bad surprise. The blobs are provided, from my >> perspective, (a) for some tests in the test suite (such as >> bios-tables-test for the aarch64 target), (b) as a convenience for >> end-users that desire to build QEMU from source, without wanting to >> build OVMF from source. > > The issue with security is not unique to EDK2. Essentially all the > binary blob firmwares that QEMU distributes have this problem, since > we dont update any of them in response to upstream security issues > in any reliable timeframe. EDK2 is probably most dangerous since > its code base is relatively larger than other firmwares, but they > are all essentially doomed. > > This is why distros should generall ybuild as many of the ROMs as > possible from scratch using latest available upstream source, not > what QEMU distributes. > > I wish we would actually ship a qemu tarball which excluded all the > pre-built ROMs and bundle them in a separate add-on tarball, with a > warning that they shouldn't be used in any "virtualization" use case > in production, only for non-virtualization use cases, as described in > > https://www.qemu.org/docs/master/system/security.html > > because the latter is where security does not matter. Can we implement the lightweight variant of this, namely extend "pc-bios/README" to communicate this limitation? What you describe above could be the very first paragraph (a file-top banner) in that file. Also, it seems like "pc-bios/README" does not get installed under $PREFIX/share/qemu. That looks like a general omission around INSTALL_BLOBS / BLOBS to me. I can't remember -- was this the case (i.e., "pc-bios/README" not getting installed) before the Meson conversion too? (CC Paolo, Marc-André.) Hm... even at the time of commit 26ce90fde5ce ("Makefile: install the edk2 firmware images and their descriptors", 2019-04-17), BLOBS didn't cover the "pc-bios/README" file. Thanks, Laszlo