From: David Hildenbrand <david@redhat.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>,
Juan Quintela <quintela@redhat.com>,
qemu-devel@nongnu.org, Peter Xu <peterx@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH v3 09/13] migration/ram: Consolidate variable reset after placement in ram_load_postcopy()
Date: Fri, 6 Mar 2020 20:09:32 +0100 [thread overview]
Message-ID: <d16a5a04-18f9-976f-6c9b-8931fbefb1de@redhat.com> (raw)
In-Reply-To: <20200306163033.GF3033@work-vm>
On 06.03.20 17:30, Dr. David Alan Gilbert wrote:
> * David Hildenbrand (david@redhat.com) wrote:
>> Let's consolidate resetting the variables.
>>
>> Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>> Cc: Juan Quintela <quintela@redhat.com>
>> Cc: Peter Xu <peterx@redhat.com>
>> Signed-off-by: David Hildenbrand <david@redhat.com>
>
> Thanks, I think that's actually fixing a case where huge zero pages
> weren't placed as zero pages?
I don't see it :) Can you point out in which receive sequence it would
go wrong?
We used to set "all_zero = true" when processing the first sub-page.
Now, we set "all_zero = true" before we start to process the first sub-page.
Thanks!
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2020-03-06 19:10 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 15:52 [PATCH v3 00/13] migrate/ram: Fix resizing RAM blocks while migrating David Hildenbrand
2020-02-26 15:52 ` [PATCH v3 01/13] util: vfio-helpers: Factor out and fix processing of existing ram blocks David Hildenbrand
2020-02-26 15:52 ` [PATCH v3 02/13] stubs/ram-block: Remove stubs that are no longer needed David Hildenbrand
2020-02-26 15:52 ` [PATCH v3 03/13] numa: Teach ram block notifiers about resizeable ram blocks David Hildenbrand
2020-02-26 15:52 ` [PATCH v3 04/13] numa: Make all callbacks of ram block notifiers optional David Hildenbrand
2020-02-26 15:52 ` [PATCH v3 05/13] migration/ram: Handle RAM block resizes during precopy David Hildenbrand
2020-02-26 15:52 ` [PATCH v3 06/13] exec: Relax range check in ram_block_discard_range() David Hildenbrand
2020-02-26 15:52 ` [PATCH v3 07/13] migration/ram: Discard RAM when growing RAM blocks after ram_postcopy_incoming_init() David Hildenbrand
2020-02-26 15:52 ` [PATCH v3 08/13] migration/ram: Simplify host page handling in ram_load_postcopy() David Hildenbrand
2020-03-06 16:05 ` Dr. David Alan Gilbert
2020-03-06 16:20 ` David Hildenbrand
2020-03-06 18:47 ` David Hildenbrand
2020-03-06 18:48 ` Dr. David Alan Gilbert
2020-02-26 15:53 ` [PATCH v3 09/13] migration/ram: Consolidate variable reset after placement " David Hildenbrand
2020-03-06 16:30 ` Dr. David Alan Gilbert
2020-03-06 19:09 ` David Hildenbrand [this message]
2020-03-06 19:11 ` Dr. David Alan Gilbert
2020-02-26 15:53 ` [PATCH v3 10/13] migration/ram: Handle RAM block resizes during postcopy David Hildenbrand
2020-03-06 16:56 ` Dr. David Alan Gilbert
2020-03-06 18:45 ` David Hildenbrand
2020-03-06 18:51 ` Dr. David Alan Gilbert
2020-02-26 15:53 ` [PATCH v3 11/13] migration/multifd: Print used_length of memory block David Hildenbrand
2020-03-06 16:57 ` Dr. David Alan Gilbert
2020-02-26 15:53 ` [PATCH v3 12/13] migration/ram: Use offset_in_ramblock() in range checks David Hildenbrand
2020-03-06 16:59 ` Dr. David Alan Gilbert
2020-02-26 15:53 ` [PATCH v3 13/13] migration/ram: Tolerate partially changed mappings in postcopy code David Hildenbrand
2020-02-26 16:06 ` Peter Xu
2020-02-26 16:08 ` David Hildenbrand
2020-02-26 16:26 ` Peter Xu
2020-02-26 16:34 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d16a5a04-18f9-976f-6c9b-8931fbefb1de@redhat.com \
--to=david@redhat.com \
--cc=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).