* [Qemu-devel] [PATCH] riscv/cpu: use device_class_set_parent_realize
@ 2018-11-26 3:20 Mao Zhongyi
2018-11-26 9:06 ` Bastian Koppelmann
2018-11-26 16:04 ` Alistair Francis
0 siblings, 2 replies; 6+ messages in thread
From: Mao Zhongyi @ 2018-11-26 3:20 UTC (permalink / raw)
To: qemu-devel, qemu-riscv
Cc: mjc, palmer, Alistair.Francis, sagark, kbastian, philmd,
Mao Zhongyi
Signed-off-by: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>
---
target/riscv/cpu.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
index a025a0a3ba..5e8a2cb2ba 100644
--- a/target/riscv/cpu.c
+++ b/target/riscv/cpu.c
@@ -330,8 +330,8 @@ static void riscv_cpu_class_init(ObjectClass *c, void *data)
CPUClass *cc = CPU_CLASS(c);
DeviceClass *dc = DEVICE_CLASS(c);
- mcc->parent_realize = dc->realize;
- dc->realize = riscv_cpu_realize;
+ device_class_set_parent_realize(dc, riscv_cpu_realize,
+ &mcc->parent_realize);
mcc->parent_reset = cc->reset;
cc->reset = riscv_cpu_reset;
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] riscv/cpu: use device_class_set_parent_realize
2018-11-26 3:20 [Qemu-devel] [PATCH] riscv/cpu: use device_class_set_parent_realize Mao Zhongyi
@ 2018-11-26 9:06 ` Bastian Koppelmann
2018-11-28 0:34 ` Palmer Dabbelt
2018-11-26 16:04 ` Alistair Francis
1 sibling, 1 reply; 6+ messages in thread
From: Bastian Koppelmann @ 2018-11-26 9:06 UTC (permalink / raw)
To: Mao Zhongyi, qemu-devel, qemu-riscv
Cc: sagark, palmer, mjc, Alistair.Francis, philmd
On 11/26/18 4:20 AM, Mao Zhongyi wrote:
> Signed-off-by: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>
> ---
> target/riscv/cpu.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Reviewed-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Cheers,
Bastian
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] riscv/cpu: use device_class_set_parent_realize
2018-11-26 3:20 [Qemu-devel] [PATCH] riscv/cpu: use device_class_set_parent_realize Mao Zhongyi
2018-11-26 9:06 ` Bastian Koppelmann
@ 2018-11-26 16:04 ` Alistair Francis
1 sibling, 0 replies; 6+ messages in thread
From: Alistair Francis @ 2018-11-26 16:04 UTC (permalink / raw)
To: maozhongyi
Cc: qemu-devel@nongnu.org Developers, qemu-riscv, Sagar Karandikar,
Bastian Koppelmann, Palmer Dabbelt, Michael Clark,
Alistair Francis, Philippe Mathieu-Daudé
On Sun, Nov 25, 2018 at 7:21 PM Mao Zhongyi
<maozhongyi@cmss.chinamobile.com> wrote:
>
> Signed-off-by: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
> target/riscv/cpu.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
> index a025a0a3ba..5e8a2cb2ba 100644
> --- a/target/riscv/cpu.c
> +++ b/target/riscv/cpu.c
> @@ -330,8 +330,8 @@ static void riscv_cpu_class_init(ObjectClass *c, void *data)
> CPUClass *cc = CPU_CLASS(c);
> DeviceClass *dc = DEVICE_CLASS(c);
>
> - mcc->parent_realize = dc->realize;
> - dc->realize = riscv_cpu_realize;
> + device_class_set_parent_realize(dc, riscv_cpu_realize,
> + &mcc->parent_realize);
>
> mcc->parent_reset = cc->reset;
> cc->reset = riscv_cpu_reset;
> --
> 2.17.1
>
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] riscv/cpu: use device_class_set_parent_realize
2018-11-26 9:06 ` Bastian Koppelmann
@ 2018-11-28 0:34 ` Palmer Dabbelt
2018-11-28 1:46 ` maozy
0 siblings, 1 reply; 6+ messages in thread
From: Palmer Dabbelt @ 2018-11-28 0:34 UTC (permalink / raw)
To: Bastian Koppelmann
Cc: maozhongyi, qemu-devel, qemu-riscv, sagark, Michael Clark,
Alistair Francis, philmd
On Mon, 26 Nov 2018 01:06:33 PST (-0800), Bastian Koppelmann wrote:
> On 11/26/18 4:20 AM, Mao Zhongyi wrote:
>> Signed-off-by: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>
>> ---
>> target/riscv/cpu.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>
> Reviewed-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Shouldn't we also use device_class_set_parent_reset right below this? Either
way, I'll queue this one for 3.2.
Thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] riscv/cpu: use device_class_set_parent_realize
2018-11-28 0:34 ` Palmer Dabbelt
@ 2018-11-28 1:46 ` maozy
2018-11-28 18:51 ` Palmer Dabbelt
0 siblings, 1 reply; 6+ messages in thread
From: maozy @ 2018-11-28 1:46 UTC (permalink / raw)
To: Palmer Dabbelt, Bastian Koppelmann
Cc: qemu-devel, qemu-riscv, sagark, Michael Clark, Alistair Francis,
philmd
Hi, Palmer
On 11/28/18 8:34 AM, Palmer Dabbelt wrote:
> On Mon, 26 Nov 2018 01:06:33 PST (-0800), Bastian Koppelmann wrote:
>> On 11/26/18 4:20 AM, Mao Zhongyi wrote:
>>> Signed-off-by: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>
>>> ---
>>> target/riscv/cpu.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>
>> Reviewed-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
>
> Shouldn't we also use device_class_set_parent_reset right below this?
device_class_set_parent_reset only used for DeviceClass *dc->reset, here
is CPUClass *cc->reset.
Thanks,
Mao
> Either
> way, I'll queue this one for 3.2.
>
> Thanks!
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] riscv/cpu: use device_class_set_parent_realize
2018-11-28 1:46 ` maozy
@ 2018-11-28 18:51 ` Palmer Dabbelt
0 siblings, 0 replies; 6+ messages in thread
From: Palmer Dabbelt @ 2018-11-28 18:51 UTC (permalink / raw)
To: maozhongyi
Cc: Bastian Koppelmann, qemu-devel, qemu-riscv, sagark, Michael Clark,
Alistair Francis, philmd
On Tue, 27 Nov 2018 17:46:04 PST (-0800), maozhongyi@cmss.chinamobile.com wrote:
> Hi, Palmer
>
> On 11/28/18 8:34 AM, Palmer Dabbelt wrote:
>> On Mon, 26 Nov 2018 01:06:33 PST (-0800), Bastian Koppelmann wrote:
>>> On 11/26/18 4:20 AM, Mao Zhongyi wrote:
>>>> Signed-off-by: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>
>>>> ---
>>>> target/riscv/cpu.c | 4 ++--
>>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>
>>> Reviewed-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
>>
>> Shouldn't we also use device_class_set_parent_reset right below this?
>
> device_class_set_parent_reset only used for DeviceClass *dc->reset, here
> is CPUClass *cc->reset.
Ah, OK, I didn't look closely enough.
> Thanks,
> Mao
>
>> Either
>> way, I'll queue this one for 3.2.
>>
>> Thanks!
>>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-11-28 18:51 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-26 3:20 [Qemu-devel] [PATCH] riscv/cpu: use device_class_set_parent_realize Mao Zhongyi
2018-11-26 9:06 ` Bastian Koppelmann
2018-11-28 0:34 ` Palmer Dabbelt
2018-11-28 1:46 ` maozy
2018-11-28 18:51 ` Palmer Dabbelt
2018-11-26 16:04 ` Alistair Francis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).