From: Thomas Huth <thuth@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>, mst@redhat.com
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/4] tests/pxe-test: Remove unnecessary special case test functions
Date: Fri, 15 Dec 2017 11:54:25 +0100 [thread overview]
Message-ID: <d17e16a4-3262-2105-eb4f-f2d378cd7676@redhat.com> (raw)
In-Reply-To: <20171215101651.13911-2-david@gibson.dropbear.id.au>
On 15.12.2017 11:16, David Gibson wrote:
> All of the x86 and some of the other test cases here use a common test
> function, test_pxe_ipv4(), but one ppc and one s390 test use different
> functions.
>
> In the s390 case, this is completely pointless, the right parameter to
> test_pxe_ipv4() will already do exactly the right thing. For the
> spapr-vlan case there's a slight difference - it will use IPv6 instead of
> IPv4.
>
> But testing just one case with IPv6 (and NOT IPv4) is rather haphazard.
> Change everything to use the common test function, until we have a better
> way of testing IPv6 across the board.
>
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> tests/pxe-test.c | 15 +++------------
> 1 file changed, 3 insertions(+), 12 deletions(-)
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2017-12-15 10:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-15 10:16 [Qemu-devel] [PATCH 0/4] Improvements to pxe-test David Gibson
2017-12-15 10:16 ` [Qemu-devel] [PATCH 1/4] tests/pxe-test: Remove unnecessary special case test functions David Gibson
2017-12-15 10:54 ` Thomas Huth [this message]
2017-12-15 10:16 ` [Qemu-devel] [PATCH 2/4] tests/pxe-test: Use table of testcases rather than open-coding David Gibson
2017-12-15 11:08 ` Thomas Huth
2017-12-15 12:54 ` David Gibson
2017-12-15 10:16 ` [Qemu-devel] [PATCH 3/4] tests/pxe-test: Test net booting over IPv6 in some cases David Gibson
2017-12-15 11:10 ` Thomas Huth
2017-12-15 12:56 ` David Gibson
2017-12-15 14:15 ` [Qemu-devel] [Qemu-ppc] " Thomas Huth
2017-12-15 10:16 ` [Qemu-devel] [PATCH 4/4] tests/pxe-test: Add some extra tests David Gibson
2017-12-15 10:51 ` Thomas Huth
2017-12-15 12:59 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d17e16a4-3262-2105-eb4f-f2d378cd7676@redhat.com \
--to=thuth@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).