From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46905) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ePndT-000851-9J for qemu-devel@nongnu.org; Fri, 15 Dec 2017 05:54:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ePndP-0006zX-9g for qemu-devel@nongnu.org; Fri, 15 Dec 2017 05:54:35 -0500 References: <20171215101651.13911-1-david@gibson.dropbear.id.au> <20171215101651.13911-2-david@gibson.dropbear.id.au> From: Thomas Huth Message-ID: Date: Fri, 15 Dec 2017 11:54:25 +0100 MIME-Version: 1.0 In-Reply-To: <20171215101651.13911-2-david@gibson.dropbear.id.au> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/4] tests/pxe-test: Remove unnecessary special case test functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson , mst@redhat.com Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org On 15.12.2017 11:16, David Gibson wrote: > All of the x86 and some of the other test cases here use a common test > function, test_pxe_ipv4(), but one ppc and one s390 test use different > functions. > > In the s390 case, this is completely pointless, the right parameter to > test_pxe_ipv4() will already do exactly the right thing. For the > spapr-vlan case there's a slight difference - it will use IPv6 instead of > IPv4. > > But testing just one case with IPv6 (and NOT IPv4) is rather haphazard. > Change everything to use the common test function, until we have a better > way of testing IPv6 across the board. > > Signed-off-by: David Gibson > --- > tests/pxe-test.c | 15 +++------------ > 1 file changed, 3 insertions(+), 12 deletions(-) Reviewed-by: Thomas Huth