From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: BALATON Zoltan <balaton@eik.bme.hu>, qemu-devel@nongnu.org
Cc: Huacai Chen <chenhuacai@kernel.org>, Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH 1/4] vt82c686: Move common code to via_isa_realize
Date: Sun, 17 Oct 2021 18:22:23 +0200 [thread overview]
Message-ID: <d17fcc21-dca8-4f69-800f-6fccb213d81e@amsat.org> (raw)
In-Reply-To: <7cb7a16ff4daf8f48d576246255bea1fd355207c.1634259980.git.balaton@eik.bme.hu>
On 10/15/21 03:06, BALATON Zoltan wrote:
> The vt82c686b_realize and vt8231_realize methods are almost identical,
> factor out the common parts to a via_isa_realize function to avoid
> code duplication.
>
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
> hw/isa/vt82c686.c | 67 ++++++++++++++++++++---------------------------
> 1 file changed, 29 insertions(+), 38 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
next prev parent reply other threads:[~2021-10-17 16:26 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-15 1:06 [PATCH 0/4] Avoid using isa_get_irq in vt82c686 model BALATON Zoltan
2021-10-15 1:06 ` [PATCH 1/4] vt82c686: Move common code to via_isa_realize BALATON Zoltan
2021-10-15 21:48 ` Jiaxun Yang
2021-10-17 16:22 ` Philippe Mathieu-Daudé [this message]
2021-10-15 1:06 ` [PATCH 2/4] vt82c686: Add a method to VIA_ISA to raise ISA interrupts BALATON Zoltan
2021-10-15 21:49 ` Jiaxun Yang
2021-10-17 16:23 ` Philippe Mathieu-Daudé
2021-10-15 1:06 ` [PATCH 3/4] hw/usb/vt82c686-uhci-pci: Avoid using isa_get_irq() BALATON Zoltan
2021-10-17 16:24 ` Philippe Mathieu-Daudé
2021-10-15 1:06 ` [PATCH 4/4] via-ide: " BALATON Zoltan
2021-10-17 16:31 ` Philippe Mathieu-Daudé
2021-10-17 18:44 ` BALATON Zoltan
2021-10-17 20:28 ` Philippe Mathieu-Daudé
2021-10-17 20:34 ` BALATON Zoltan
2021-10-18 6:19 ` Gerd Hoffmann
2021-10-18 9:46 ` BALATON Zoltan
2021-10-17 19:39 ` BALATON Zoltan
2021-10-17 20:25 ` Philippe Mathieu-Daudé
2021-10-17 20:31 ` BALATON Zoltan
2021-10-15 9:16 ` [PATCH] via-ide: Set user_creatable to false BALATON Zoltan
2021-10-17 16:19 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d17fcc21-dca8-4f69-800f-6fccb213d81e@amsat.org \
--to=f4bug@amsat.org \
--cc=balaton@eik.bme.hu \
--cc=chenhuacai@kernel.org \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).