From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, thuth@redhat.com, jsnow@redhat.com,
ehabkost@redhat.com, mreitz@redhat.com
Subject: Re: [PATCH v2 0/2] iotests: Require Python 3.6 or later
Date: Thu, 19 Sep 2019 19:15:49 +0200 [thread overview]
Message-ID: <d19b2194-4880-94fd-57e5-8bea73dcbc2f@redhat.com> (raw)
In-Reply-To: <20190919162905.21830-1-kwolf@redhat.com>
On 9/19/19 6:29 PM, Kevin Wolf wrote:
> v2:
>
> - Provide the right exit code from Python instead of having a
> potentially confusing negation in the shell script
>
> - Raised the minimal version to 3.6. If we're going to use a different
> version than QEMU as a whole anyway, we can use a version that suits
> us best. 3.5 would only be for Debian Stretch, and we don't really
> care that much about running Python test cases on it.
>
> - Added a patch to remove Python 2 compatibility code
>
> Kevin Wolf (2):
> iotests: Require Python 3.6 or later
> iotests: Remove Python 2 compatibility code
>
> tests/qemu-iotests/044 | 3 ---
> tests/qemu-iotests/163 | 3 ---
> tests/qemu-iotests/check | 13 ++++++++++++-
> tests/qemu-iotests/iotests.py | 13 +++----------
> tests/qemu-iotests/nbd-fault-injector.py | 7 +++----
> 5 files changed, 18 insertions(+), 21 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
prev parent reply other threads:[~2019-09-19 17:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-19 16:29 [PATCH v2 0/2] iotests: Require Python 3.6 or later Kevin Wolf
2019-09-19 16:29 ` [PATCH v2 1/2] " Kevin Wolf
2019-09-19 16:38 ` Eduardo Habkost
2019-09-19 16:41 ` Thomas Huth
2019-09-20 8:40 ` Vladimir Sementsov-Ogievskiy
2019-09-20 9:27 ` Kevin Wolf
2019-09-20 9:44 ` Vladimir Sementsov-Ogievskiy
2019-09-19 16:29 ` [PATCH v2 2/2] iotests: Remove Python 2 compatibility code Kevin Wolf
2019-09-19 16:38 ` Eduardo Habkost
2019-09-19 16:42 ` Thomas Huth
2019-09-19 19:14 ` John Snow
2019-09-20 8:51 ` Vladimir Sementsov-Ogievskiy
2019-09-19 17:15 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d19b2194-4880-94fd-57e5-8bea73dcbc2f@redhat.com \
--to=philmd@redhat.com \
--cc=ehabkost@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).