From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59341) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZIU0-0002jE-UM for qemu-devel@nongnu.org; Mon, 15 Aug 2016 10:03:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bZITw-0004ax-Lz for qemu-devel@nongnu.org; Mon, 15 Aug 2016 10:03:15 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:62887 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZITw-0004at-G9 for qemu-devel@nongnu.org; Mon, 15 Aug 2016 10:03:12 -0400 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u7FDwsfo005210 for ; Mon, 15 Aug 2016 10:03:12 -0400 Received: from e06smtp11.uk.ibm.com (e06smtp11.uk.ibm.com [195.75.94.107]) by mx0b-001b2d01.pphosted.com with ESMTP id 24tgu24jn4-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Mon, 15 Aug 2016 10:03:11 -0400 Received: from localhost by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 15 Aug 2016 15:03:10 +0100 Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 4071F17D805A for ; Mon, 15 Aug 2016 15:04:48 +0100 (BST) Received: from d06av06.portsmouth.uk.ibm.com (d06av06.portsmouth.uk.ibm.com [9.149.37.217]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u7FE36rp30081168 for ; Mon, 15 Aug 2016 14:03:06 GMT Received: from d06av06.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av06.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u7FE358c021440 for ; Mon, 15 Aug 2016 10:03:05 -0400 References: <1470670378-53732-1-git-send-email-dahi@linux.vnet.ibm.com> <20160815160023.1a11e851@thinkpad-w530> From: Christian Borntraeger Date: Mon, 15 Aug 2016 16:03:04 +0200 MIME-Version: 1.0 In-Reply-To: <20160815160023.1a11e851@thinkpad-w530> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Message-Id: Subject: Re: [Qemu-devel] [Patch v2 00/29] s390x CPU models: exposing features List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Hildenbrand , qemu-devel@nongnu.org Cc: ehabkost@redhat.com, fiuczy@linux.vnet.ibm.com, cornelia.huck@de.ibm.com, imammedo@redhat.com, jdenemar@redhat.com, mimu@linux.vnet.ibm.com On 08/15/2016 04:00 PM, David Hildenbrand wrote: > > I'll wait a bit until sending out another series that fixes two minor style > problems. > > What about > 80 chars per line. Is it okay for these definitions + function > prototype or a no-go? As long as we are < 90 I think its better than wrapping.