From: Paolo Bonzini <pbonzini@redhat.com>
To: Ashijeet Acharya <ashijeetacharya@gmail.com>
Cc: lcapitulino@redhat.com, quintela@redhat.com,
amit.shah@redhat.com, eblake@redhat.com, armbru@redhat.com,
"dgilbert@redhat.com" <dgilbert@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v2] Move migrate_set_speed and migrate_set_downtime into migrate_set_parameter
Date: Mon, 5 Sep 2016 15:16:04 +0200 [thread overview]
Message-ID: <d1d1ae03-6d6a-df60-d6e6-c8d11b595f41@redhat.com> (raw)
In-Reply-To: <CAC2QTZY6M9OpAA9cY+xk1AcJf6fd15oaP-wSY9CSm_8P9P_Grw@mail.gmail.com>
On 05/09/2016 15:09, Ashijeet Acharya wrote:
>>> >> + "compress-level:i?,compress-threads:i?,decompress-threads:i?,cpu-throttle-initial:i?,cpu-throttle-increment:i?,migrate-set-speed:o?,migrate-set-downtime:T?",
>> >
>> > Same here about the names. Also use "i" for QMP commands.
> I think we will have to use "T" for downtime at-least otherwise you
> cant use float values for setting seconds like "0.2" for example.
> No issues using "i" with bandwidth though.
Right, I should have mentioned that my remark was about the "o" (it
caught my eye because of your change to hmp-commands.hx). Sorry!
Paolo
next prev parent reply other threads:[~2016-09-05 13:16 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-05 7:45 [Qemu-devel] [PATCH] Move migrate_set_speed and migrate_set_downtime into migrate_set_parameter Ashijeet Acharya
2016-09-05 8:01 ` Paolo Bonzini
2016-09-05 8:11 ` Ashijeet Acharya
2016-09-05 8:16 ` Paolo Bonzini
2016-09-05 8:25 ` Ashijeet Acharya
2016-09-05 11:16 ` Dr. David Alan Gilbert
2016-09-05 11:37 ` [Qemu-devel] [PATCH v2] " Ashijeet Acharya
2016-09-05 11:45 ` Paolo Bonzini
2016-09-05 11:59 ` Ashijeet Acharya
2016-09-05 12:01 ` Paolo Bonzini
2016-09-05 12:08 ` Ashijeet Acharya
2016-09-05 13:09 ` Ashijeet Acharya
2016-09-05 13:16 ` Paolo Bonzini [this message]
2016-09-05 14:26 ` [Qemu-devel] [PATCH v3] " Ashijeet Acharya
2016-09-05 14:36 ` Daniel P. Berrange
2016-09-05 15:14 ` Ashijeet Acharya
2016-09-05 15:39 ` Daniel P. Berrange
2016-09-05 15:46 ` Ashijeet Acharya
2016-09-05 14:28 ` [Qemu-devel] [PATCH v3] Move migrate_set_speed and migrate_set_downtime into migrate_set_parameter (reversed logic) Ashijeet Acharya
2016-09-05 15:56 ` [Qemu-devel] [PATCH v2] Move migrate_set_speed and migrate_set_downtime into migrate_set_parameter Daniel P. Berrange
2016-09-06 8:16 ` Markus Armbruster
2016-09-06 13:16 ` [Qemu-devel] [PATCH] " Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1d1ae03-6d6a-df60-d6e6-c8d11b595f41@redhat.com \
--to=pbonzini@redhat.com \
--cc=amit.shah@redhat.com \
--cc=armbru@redhat.com \
--cc=ashijeetacharya@gmail.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).