From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53067) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bgtl1-0008W4-KW for qemu-devel@nongnu.org; Mon, 05 Sep 2016 09:16:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bgtkv-0002EX-DG for qemu-devel@nongnu.org; Mon, 05 Sep 2016 09:16:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60702) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bgtkv-0002EG-7y for qemu-devel@nongnu.org; Mon, 05 Sep 2016 09:16:09 -0400 References: <20160905111620.GA22359@work-vm> <1473075436-32489-1-git-send-email-ashijeetacharya@gmail.com> <122bc56c-0025-695a-8e2f-63aa03377879@redhat.com> From: Paolo Bonzini Message-ID: Date: Mon, 5 Sep 2016 15:16:04 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] Move migrate_set_speed and migrate_set_downtime into migrate_set_parameter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ashijeet Acharya Cc: lcapitulino@redhat.com, quintela@redhat.com, amit.shah@redhat.com, eblake@redhat.com, armbru@redhat.com, "dgilbert@redhat.com" , QEMU Developers On 05/09/2016 15:09, Ashijeet Acharya wrote: >>> >> + "compress-level:i?,compress-threads:i?,decompress-threads:i?,cpu-throttle-initial:i?,cpu-throttle-increment:i?,migrate-set-speed:o?,migrate-set-downtime:T?", >> > >> > Same here about the names. Also use "i" for QMP commands. > I think we will have to use "T" for downtime at-least otherwise you > cant use float values for setting seconds like "0.2" for example. > No issues using "i" with bandwidth though. Right, I should have mentioned that my remark was about the "o" (it caught my eye because of your change to hmp-commands.hx). Sorry! Paolo