From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7462CC7EE23 for ; Tue, 30 May 2023 13:01:16 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q3yyG-0007q6-QK; Tue, 30 May 2023 09:01:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q3yyA-0007lc-0p for qemu-devel@nongnu.org; Tue, 30 May 2023 09:00:58 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q3yy8-0001Bc-EX for qemu-devel@nongnu.org; Tue, 30 May 2023 09:00:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685451654; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Lnmb/tQ/TLRa65N+AEWkyiFiWwukdsQS3Rgu1RC68z4=; b=BcNeWwCDIKV8e8AISiRSAkU6eK8275u8haMH23rn+nO+4G6yA4kfsoe3CTKyYCCQp7AOlj GkXNv5bvsvCVWcmGuODqkDkf43/CRdSbRZvpCT1DBrhsnr1syJMO/wwvGBWoJxhCk0daNN IynpSBJhiwTPeHnioLndrdE1kTJV2aw= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-101-9tiYY-ZyP_SmcbLzZGJeAw-1; Tue, 30 May 2023 09:00:53 -0400 X-MC-Unique: 9tiYY-ZyP_SmcbLzZGJeAw-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-3f41a04a297so18534745e9.3 for ; Tue, 30 May 2023 06:00:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685451652; x=1688043652; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Lnmb/tQ/TLRa65N+AEWkyiFiWwukdsQS3Rgu1RC68z4=; b=lBbhrONfzwV/f73H98brbINEEqEbNHqf+GrYFpjlOJPKFGI/BDbWfQTsk6jbRIBk6R 1GByixXicytZSj7VQsH2EUqOhDlDo2rhViUgAXhdAPfgcQrrIDKsCrzAyMgVMdToLcpH 2edEHegO0/OloyZ90Uh9Oe7P4knu1QQzBvibdV72zfL59kyzHZdT0qRjDpPku/MKMDDK BOHhIbyWjTa2A0Ws/T8vV9SxugyiDFvIDeADzdqXkLWcK2LB6nfLJ8rfkxRNUfEaNFCf nvAwHk2s7HKaIk4dpcKdf5PmpWP2nFwKpKMp9WWKSGVskBiEKnNVB4BwkSslUkgc97NZ 9Pag== X-Gm-Message-State: AC+VfDzG2nl2rUfjl+qnSPbAtbfcm5B/lVwEWvUmfhQS3UY5HyCcrgwD b644KpO4RKINY7wyXk7gmwrCQdlGAtWYDrjO2YMaonTHPX/2d00BnglZISaCKg/BsTUeOiX5Cvo uQrSe8rxM9bXUHuc= X-Received: by 2002:a1c:6a12:0:b0:3f4:2492:a91f with SMTP id f18-20020a1c6a12000000b003f42492a91fmr1480397wmc.27.1685451652111; Tue, 30 May 2023 06:00:52 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6f4zRldqI4IvRlNXThYhrhzC34Jw/rmBmvvP1YQXkzYcNE096oGYteDtfVLxKASbTzAvomqA== X-Received: by 2002:a1c:6a12:0:b0:3f4:2492:a91f with SMTP id f18-20020a1c6a12000000b003f42492a91fmr1480382wmc.27.1685451651853; Tue, 30 May 2023 06:00:51 -0700 (PDT) Received: from [192.168.0.3] (ip-109-43-176-11.web.vodafone.de. [109.43.176.11]) by smtp.gmail.com with ESMTPSA id a14-20020adfe5ce000000b003078354f774sm3277491wrn.36.2023.05.30.06.00.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 May 2023 06:00:49 -0700 (PDT) Message-ID: Date: Tue, 30 May 2023 15:00:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 4/5] configure: check for SLOF submodule before building pc-bios/s390-ccw Content-Language: en-US To: Paolo Bonzini Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org, berrange@redhat.com References: <20230527092851.705884-1-pbonzini@redhat.com> <20230527092851.705884-5-pbonzini@redhat.com> <1981c8e3-9109-7562-0d64-1fa091a28e3c@redhat.com> From: Thomas Huth In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.167, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.09, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 30/05/2023 14.53, Paolo Bonzini wrote: > On Tue, May 30, 2023 at 2:04 PM Thomas Huth wrote: >> On 27/05/2023 11.28, Paolo Bonzini wrote: >>> SLOF is required for building the s390-ccw firmware on s390x, >>> since it is using the libnet code from SLOF for network booting. >>> >>> If SLOF is absent and submodules are not updated, pc-bios/s390-ccw >>> cannot be built. >>> >>> Signed-off-by: Paolo Bonzini >>> --- >>> configure | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/configure b/configure >>> index 1d1b8736c0eb..c92a3b30b9a4 100755 >>> --- a/configure >>> +++ b/configure >>> @@ -1662,7 +1662,8 @@ fi >>> >>> # Only build s390-ccw bios if the compiler has -march=z900 or -march=z10 >>> # (which is the lowest architecture level that Clang supports) >>> -if have_target s390x-softmmu && probe_target_compiler s390x-softmmu; then >>> +if have_target s390x-softmmu && probe_target_compiler s390x-softmmu && \ >>> + ( test "$git_submodules_action" != ignore || test -f roms/SLOF/VERSION ); then >>> write_c_skeleton >>> do_compiler "$target_cc" $target_cc_cflags -march=z900 -o $TMPO -c $TMPC >>> has_z900=$? >> >> Not sure if we really need this. Only the networking part of the s390-ccw >> bios cannot be build without SLOF, but the main binary still builds fine >> also without it. > > Thinking more about it---considering we have prebuilt s390-ccw > binaries, why would someone want to rebuild only one of the ROMs and > risk breaking the other? Should we keep this patch, and also include > $(SRC_PATH)/netboot.mak unconditionally from > pc-bios/s390-ccw/Makefile? Yes, I think it makes sense nowadays. In the beginning, the network bootloader was considered experimental and thus optional, but I think it is well established nowadays, so it makes sense to always build it together with the other part of the s390-ccw bios. Thomas