From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4C95DC87FD2 for ; Mon, 11 Aug 2025 12:25:06 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ulRaD-0003QT-N1; Mon, 11 Aug 2025 08:24:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ulRa0-00038s-Md for qemu-devel@nongnu.org; Mon, 11 Aug 2025 08:24:46 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ulRZq-00074Q-Vn for qemu-devel@nongnu.org; Mon, 11 Aug 2025 08:24:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1754915066; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ZNDNwdUBEdA+RwgREB/qeqZvHlrty3zXHwgfYyraMis=; b=YXtv3ZQY+I5kj9skp8uFIMtG61iQGwBrvLorEF3OKBN52E1qE6m5j77yeafHULJBl1YzAs 9d2mbVcmos4VmCfntE+PFtf5o4Gr1RecmNt9cdbSSQmw2PJX2DkfG6pSLNQxYlTiXAvTfv 5AF20ubHP3OZ+O7uUhlsYeSHBXOAGio= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-484-riNfy6FYMSq2__uG_qhBSA-1; Mon, 11 Aug 2025 08:24:25 -0400 X-MC-Unique: riNfy6FYMSq2__uG_qhBSA-1 X-Mimecast-MFC-AGG-ID: riNfy6FYMSq2__uG_qhBSA_1754915065 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-7074f138855so79633046d6.1 for ; Mon, 11 Aug 2025 05:24:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754915065; x=1755519865; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZNDNwdUBEdA+RwgREB/qeqZvHlrty3zXHwgfYyraMis=; b=Jxkwwyey+5h+EeEukXR5dIAD+6kaHYOKCGTIzkgL5qHobiabTrhiYS/kOxXAfwOT94 0d7uEaR+RNwopxg0RUoSRJcxPAZZ5JnD6irrfsZmgU2hyFjh0weIxPw5t63ZwsmmI4LC J2kGWpS/1wihbT/9RJw9sF8N8MVaRTCxzNvbZlMkekmV/YmVE3drgkDtxw4OuBqc4vBU nV4BeFbj+YOxiDsNrNmj9eFxJAo/nI6VfLi2y/FuPaM2EAaDxzLyE+VW6Hd4ImsIhOHb wP/bWgtewoTjgjflpfVp1sgKbaNbwX6cIOAC91yepi+WMOrAfyhzkSoFMqd3cHP28EC+ Ffqg== X-Forwarded-Encrypted: i=1; AJvYcCXp2eiIaPEF3HUxTL8Ph+bc+f3zU527qnTbM02c9H4TAKp0oz5Ut+rfUIZxL4spTDNIJuPEZhIFv+6N@nongnu.org X-Gm-Message-State: AOJu0Yzj2fbs+xCVYn4Ux3u0BWc1g7nJIKze3qYZ880eTcdke2Y8XVgZ bwAGLOffyl3vRHZ78HZz5etIM0hirQq0CoYYIfRmZoFMLZpb/1nNVAicUgxKWhEpsW3QbWCRWW+ yMrwRSnSwT+836ho/1LpcLAg3Suht5XpMagUUlQ2LpWvHwC0MNGzRC5kX X-Gm-Gg: ASbGncuLmSbcP4hl62tS+ahJnBxz66ShYChaQb7LLL6/VZERyQvbsELQnS5hTgj2Vjc Yxe8S0prFDWO106fKshaMRWAUvxlePXya6sVQaKb4DGgfaRo5HDPYL8xdYamIi5Nnt+2lrr2hvJ ni/PvQLVAp/lnnD5KrnF+wSnRKzi61Ogcv2Cv6RVTqstyPFLu6del2O5v9yiVpffOQWN/xcyG06 lOOhWEbADTEsh1BEI1F5xrdlo7LLhWSR7RakPmOXwTqEsEKPuaSP6aW92kkEbac2TUnAI8j0iuJ ZG5QR2oBBWdmQpeZGAtvIGq6R1aoCl7XHlTzJNszujafbpq83yn2Ip98oqiJr6MxCdn50YFOrIl lig== X-Received: by 2002:a05:6214:5c82:b0:709:9e64:93f5 with SMTP id 6a1803df08f44-7099e64973amr133467616d6.41.1754915065179; Mon, 11 Aug 2025 05:24:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGNZW5ImDKv49ImmOs2lVgJaMJlwCkygyTQIbuLUPRtpaE1lCTtPFwHyt+K6OZtQ/1ljfiBow== X-Received: by 2002:a05:6214:5c82:b0:709:9e64:93f5 with SMTP id 6a1803df08f44-7099e64973amr133467306d6.41.1754915064836; Mon, 11 Aug 2025 05:24:24 -0700 (PDT) Received: from ?IPV6:2a01:e0a:280:24f0:576b:abc6:6396:ed4a? ([2a01:e0a:280:24f0:576b:abc6:6396:ed4a]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-7077c9d6d6csm154710566d6.4.2025.08.11.05.24.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Aug 2025 05:24:24 -0700 (PDT) Message-ID: Date: Mon, 11 Aug 2025 14:24:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 11/22] vfio-user/pci.c: update VFIOUserPCIDevice declaration To: Mark Cave-Ayland , npiggin@gmail.com, danielhb413@gmail.com, harshpb@linux.ibm.com, mjrosato@linux.ibm.com, farman@linux.ibm.com, pasic@linux.ibm.com, borntraeger@linux.ibm.com, thuth@redhat.com, richard.henderson@linaro.org, david@redhat.com, iii@linux.ibm.com, john.levon@nutanix.com, thanos.makatos@nutanix.com, alex.williamson@redhat.com, steven.sistare@oracle.com, tomitamoeko@gmail.com, qemu-ppc@nongnu.org, qemu-s390x@nongnu.org, qemu-devel@nongnu.org References: <20250715093110.107317-1-mark.caveayland@nutanix.com> <20250715093110.107317-12-mark.caveayland@nutanix.com> From: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= Content-Language: en-US, fr Autocrypt: addr=clg@redhat.com; keydata= xsFNBFu8o3UBEADP+oJVJaWm5vzZa/iLgpBAuzxSmNYhURZH+guITvSySk30YWfLYGBWQgeo 8NzNXBY3cH7JX3/a0jzmhDc0U61qFxVgrPqs1PQOjp7yRSFuDAnjtRqNvWkvlnRWLFq4+U5t yzYe4SFMjFb6Oc0xkQmaK2flmiJNnnxPttYwKBPd98WfXMmjwAv7QfwW+OL3VlTPADgzkcqj 53bfZ4VblAQrq6Ctbtu7JuUGAxSIL3XqeQlAwwLTfFGrmpY7MroE7n9Rl+hy/kuIrb/TO8n0 ZxYXvvhT7OmRKvbYuc5Jze6o7op/bJHlufY+AquYQ4dPxjPPVUT/DLiUYJ3oVBWFYNbzfOrV RxEwNuRbycttMiZWxgflsQoHF06q/2l4ttS3zsV4TDZudMq0TbCH/uJFPFsbHUN91qwwaN/+ gy1j7o6aWMz+Ib3O9dK2M/j/O/Ube95mdCqN4N/uSnDlca3YDEWrV9jO1mUS/ndOkjxa34ia 70FjwiSQAsyIwqbRO3CGmiOJqDa9qNvd2TJgAaS2WCw/TlBALjVQ7AyoPEoBPj31K74Wc4GS Rm+FSch32ei61yFu6ACdZ12i5Edt+To+hkElzjt6db/UgRUeKfzlMB7PodK7o8NBD8outJGS tsL2GRX24QvvBuusJdMiLGpNz3uqyqwzC5w0Fd34E6G94806fwARAQABzSJDw6lkcmljIExl IEdvYXRlciA8Y2xnQHJlZGhhdC5jb20+wsGRBBMBCAA7FiEEoPZlSPBIlev+awtgUaNDx8/7 7KEFAmTLlVECGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQUaNDx8/77KG0eg// S0zIzTcxkrwJ/9XgdcvVTnXLVF9V4/tZPfB7sCp8rpDCEseU6O0TkOVFoGWM39sEMiQBSvyY lHrP7p7E/JYQNNLh441MfaX8RJ5Ul3btluLapm8oHp/vbHKV2IhLcpNCfAqaQKdfk8yazYhh EdxTBlzxPcu+78uE5fF4wusmtutK0JG0sAgq0mHFZX7qKG6LIbdLdaQalZ8CCFMKUhLptW71 xe+aNrn7hScBoOj2kTDRgf9CE7svmjGToJzUxgeh9mIkxAxTu7XU+8lmL28j2L5uNuDOq9vl hM30OT+pfHmyPLtLK8+GXfFDxjea5hZLF+2yolE/ATQFt9AmOmXC+YayrcO2ZvdnKExZS1o8 VUKpZgRnkwMUUReaF/mTauRQGLuS4lDcI4DrARPyLGNbvYlpmJWnGRWCDguQ/LBPpbG7djoy k3NlvoeA757c4DgCzggViqLm0Bae320qEc6z9o0X0ePqSU2f7vcuWN49Uhox5kM5L86DzjEQ RHXndoJkeL8LmHx8DM+kx4aZt0zVfCHwmKTkSTQoAQakLpLte7tWXIio9ZKhUGPv/eHxXEoS 0rOOAZ6np1U/xNR82QbF9qr9TrTVI3GtVe7Vxmff+qoSAxJiZQCo5kt0YlWwti2fFI4xvkOi V7lyhOA3+/3oRKpZYQ86Frlo61HU3r6d9wzOwU0EW7yjdQEQALyDNNMw/08/fsyWEWjfqVhW pOOrX2h+z4q0lOHkjxi/FRIRLfXeZjFfNQNLSoL8j1y2rQOs1j1g+NV3K5hrZYYcMs0xhmrZ KXAHjjDx7FW3sG3jcGjFW5Xk4olTrZwFsZVUcP8XZlArLmkAX3UyrrXEWPSBJCXxDIW1hzwp bV/nVbo/K9XBptT/wPd+RPiOTIIRptjypGY+S23HYBDND3mtfTz/uY0Jytaio9GETj+fFis6 TxFjjbZNUxKpwftu/4RimZ7qL+uM1rG1lLWc9SPtFxRQ8uLvLOUFB1AqHixBcx7LIXSKZEFU CSLB2AE4wXQkJbApye48qnZ09zc929df5gU6hjgqV9Gk1rIfHxvTsYltA1jWalySEScmr0iS YBZjw8Nbd7SxeomAxzBv2l1Fk8fPzR7M616dtb3Z3HLjyvwAwxtfGD7VnvINPbzyibbe9c6g LxYCr23c2Ry0UfFXh6UKD83d5ybqnXrEJ5n/t1+TLGCYGzF2erVYGkQrReJe8Mld3iGVldB7 JhuAU1+d88NS3aBpNF6TbGXqlXGF6Yua6n1cOY2Yb4lO/mDKgjXd3aviqlwVlodC8AwI0Sdu jWryzL5/AGEU2sIDQCHuv1QgzmKwhE58d475KdVX/3Vt5I9kTXpvEpfW18TjlFkdHGESM/Jx IqVsqvhAJkalABEBAAHCwV8EGAECAAkFAlu8o3UCGwwACgkQUaNDx8/77KEhwg//WqVopd5k 8hQb9VVdk6RQOCTfo6wHhEqgjbXQGlaxKHoXywEQBi8eULbeMQf5l4+tHJWBxswQ93IHBQjK yKyNr4FXseUI5O20XVNYDJZUrhA4yn0e/Af0IX25d94HXQ5sMTWr1qlSK6Zu79lbH3R57w9j hQm9emQEp785ui3A5U2Lqp6nWYWXz0eUZ0Tad2zC71Gg9VazU9MXyWn749s0nXbVLcLS0yop s302Gf3ZmtgfXTX/W+M25hiVRRKCH88yr6it+OMJBUndQVAA/fE9hYom6t/zqA248j0QAV/p LHH3hSirE1mv+7jpQnhMvatrwUpeXrOiEw1nHzWCqOJUZ4SY+HmGFW0YirWV2mYKoaGO2YBU wYF7O9TI3GEEgRMBIRT98fHa0NPwtlTktVISl73LpgVscdW8yg9Gc82oe8FzU1uHjU8b10lU XOMHpqDDEV9//r4ZhkKZ9C4O+YZcTFu+mvAY3GlqivBNkmYsHYSlFsbxc37E1HpTEaSWsGfA HQoPn9qrDJgsgcbBVc1gkUT6hnxShKPp4PlsZVMNjvPAnr5TEBgHkk54HQRhhwcYv1T2QumQ izDiU6iOrUzBThaMhZO3i927SG2DwWDVzZltKrCMD1aMPvb3NU8FOYRhNmIFR3fcalYr+9gD uVKe8BVz4atMOoktmt0GWTOC8P4= In-Reply-To: <20250715093110.107317-12-mark.caveayland@nutanix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_PASS=-0.001, T_SPF_HELO_TEMPERROR=0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 7/15/25 11:25, Mark Cave-Ayland wrote: > Update the VFIOUserPCIDevice declaration so that it is closer to our coding > guidelines: add a blank line after the parent object. > > Signed-off-by: Mark Cave-Ayland Reviewed-by: Cédric Le Goater Thanks, C. > --- > hw/vfio-user/pci.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/vfio-user/pci.c b/hw/vfio-user/pci.c > index be71c77729..da6fe51809 100644 > --- a/hw/vfio-user/pci.c > +++ b/hw/vfio-user/pci.c > @@ -21,6 +21,7 @@ OBJECT_DECLARE_SIMPLE_TYPE(VFIOUserPCIDevice, VFIO_USER_PCI) > > struct VFIOUserPCIDevice { > VFIOPCIDevice device; > + > SocketAddress *socket; > bool send_queued; /* all sends are queued */ > uint32_t wait_time; /* timeout for message replies */