From: Eric Blake <eblake@redhat.com>
To: Ivan Ren <renyime@gmail.com>, mreitz@redhat.com, kwolf@redhat.com
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] qcow2: fix preallocation with metadata on bare block device
Date: Fri, 11 May 2018 08:41:27 -0500 [thread overview]
Message-ID: <d1f20f1e-69c7-bb11-3053-60bc89d06a84@redhat.com> (raw)
In-Reply-To: <1526042271-11983-1-git-send-email-ivanren@tencent.com>
On 05/11/2018 07:37 AM, Ivan Ren wrote:
> Create a qcow2 directly on bare block device with
> "-o preallocation=metadata" option. When read this qcow2, it will
> return pre-existing data on block device, and this may lead to
> data leakage. This patch add QCOW_OFLAG_ZERO for all preallocated
> l2 entry to avoid this problem.
This is a semantic change; are we okay making it?
Does your code properly check for qcow2v2 files, which don't support
QCOW_OFLAG_ZERO (only qcow2v3 supports it)?
>
> Signed-off-by: Ivan Ren <ivanren@tencent.com>
> ---
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2018-05-11 13:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-11 12:37 [Qemu-devel] [PATCH v2] qcow2: fix preallocation with metadata on bare block device Ivan Ren
2018-05-11 13:41 ` Eric Blake [this message]
2018-05-11 14:40 ` Ivan Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1f20f1e-69c7-bb11-3053-60bc89d06a84@redhat.com \
--to=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=renyime@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).