From: John Snow <jsnow@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-block@nongnu.org
Cc: fam@euphon.net, kwolf@redhat.com, armbru@redhat.com,
qemu-devel@nongnu.org, mreitz@redhat.com, den@openvz.org
Subject: Re: [PATCH v3 0/3] proper locking on bitmap add/remove paths
Date: Thu, 26 Sep 2019 15:28:44 -0400 [thread overview]
Message-ID: <d1f2ea25-ade5-174e-7157-24f6ee442003@redhat.com> (raw)
In-Reply-To: <20190920082543.23444-1-vsementsov@virtuozzo.com>
On 9/20/19 4:25 AM, Vladimir Sementsov-Ogievskiy wrote:
> Hi all!
>
> We need to lock qcow2 mutex on accessing in-image metadata, especially
> on updating this metadata. Let's implement it.
>
> v3:
> 01: add John's r-b
> 02: - fix bdrv_remove_persistent_dirty_bitmap return value
> - drop extra zeroing of ret in qcow2_remove_persistent_dirty_bitmap
> 03: add John's r-b
>
> Vladimir Sementsov-Ogievskiy (3):
> block: move bdrv_can_store_new_dirty_bitmap to block/dirty-bitmap.c
> block/dirty-bitmap: return int from
> bdrv_remove_persistent_dirty_bitmap
> block/qcow2: proper locking on bitmap add/remove paths
>
> block/qcow2.h | 14 ++---
> include/block/block_int.h | 14 ++---
> include/block/dirty-bitmap.h | 5 +-
> block.c | 22 -------
> block/dirty-bitmap.c | 119 +++++++++++++++++++++++++++++++++--
> block/qcow2-bitmap.c | 36 +++++++----
> block/qcow2.c | 5 +-
> blockdev.c | 28 +++------
> 8 files changed, 163 insertions(+), 80 deletions(-)
>
Thanks, applied to my bitmaps tree:
https://github.com/jnsnow/qemu/commits/bitmaps
https://github.com/jnsnow/qemu.git
--js
prev parent reply other threads:[~2019-09-26 19:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 8:25 [PATCH v3 0/3] proper locking on bitmap add/remove paths Vladimir Sementsov-Ogievskiy
2019-09-20 8:25 ` [PATCH v3 1/3] block: move bdrv_can_store_new_dirty_bitmap to block/dirty-bitmap.c Vladimir Sementsov-Ogievskiy
2019-09-20 8:25 ` [PATCH v3 2/3] block/dirty-bitmap: return int from bdrv_remove_persistent_dirty_bitmap Vladimir Sementsov-Ogievskiy
2019-09-26 19:02 ` John Snow
2019-09-20 8:25 ` [PATCH v3 3/3] block/qcow2: proper locking on bitmap add/remove paths Vladimir Sementsov-Ogievskiy
2019-09-26 19:01 ` [PATCH v3 0/3] " John Snow
2019-09-27 8:37 ` Vladimir Sementsov-Ogievskiy
2019-09-27 16:56 ` John Snow
2019-09-26 19:28 ` John Snow [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1f2ea25-ade5-174e-7157-24f6ee442003@redhat.com \
--to=jsnow@redhat.com \
--cc=armbru@redhat.com \
--cc=den@openvz.org \
--cc=fam@euphon.net \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).