From: Richard Henderson <richard.henderson@linaro.org>
To: Stefan Weil <sw@weilnetz.de>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] oslib-posix: Fix compiler warning
Date: Tue, 10 Oct 2017 07:43:05 -0700 [thread overview]
Message-ID: <d2025f3e-d54d-e5d0-d834-6e088a6f09ec@linaro.org> (raw)
In-Reply-To: <c01459d1-81f4-8af3-4e52-f7703ff389ea@weilnetz.de>
On 10/09/2017 10:39 PM, Stefan Weil wrote:
> Am 09.10.2017 um 23:58 schrieb Richard Henderson:
>> On 10/07/2017 08:55 AM, Stefan Weil wrote:
>>> + char *addr = memset_args->addr;
>>> + uint64_t numpages = memset_args->numpages;
>>> + uint64_t hpagesize = memset_args->hpagesize;
>>> + unsigned i;
>>
>> Match numpages properly while you're at it?
>>
>>
>> r~
>
> Do you mean using uint64_t for the loop variable i?
Yes.
> Sure. I only hesitated to do that because it is so huge.
> A 64 bit loop variable looks strange, and the loop would
> take some time if it really uses that range. :-)
Why would we use a 64-bit variable for numpages if we don't expect such a
value? What I see, from spot review only, is an apparent bug -- the iterator
type does not match the bound type.
r~
next prev parent reply other threads:[~2017-10-10 14:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-07 15:55 [Qemu-devel] [PATCH] oslib-posix: Fix compiler warning Stefan Weil
2017-10-09 21:58 ` Richard Henderson
2017-10-10 5:39 ` Stefan Weil
2017-10-10 14:43 ` Richard Henderson [this message]
2017-10-10 16:48 ` Stefan Weil
2017-10-10 17:17 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2025f3e-d54d-e5d0-d834-6e088a6f09ec@linaro.org \
--to=richard.henderson@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).