* [PATCH] target/arm: Fix 64-bit SSRA
@ 2023-08-21 2:20 Richard Henderson
2023-08-21 3:00 ` Richard Henderson
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Richard Henderson @ 2023-08-21 2:20 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm, qemu-stable
Typo applied byte-wise shift instead of double-word shift.
Cc: qemu-stable@nongnu.org
Fixes: 631e565450c ("target/arm: Create gen_gvec_[us]sra")
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1779
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/tcg/translate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/arm/tcg/translate.c b/target/arm/tcg/translate.c
index b71ac2d0d5..39541ecdf0 100644
--- a/target/arm/tcg/translate.c
+++ b/target/arm/tcg/translate.c
@@ -3053,7 +3053,7 @@ void gen_gvec_ssra(unsigned vece, uint32_t rd_ofs, uint32_t rm_ofs,
.vece = MO_32 },
{ .fni8 = gen_ssra64_i64,
.fniv = gen_ssra_vec,
- .fno = gen_helper_gvec_ssra_b,
+ .fno = gen_helper_gvec_ssra_d,
.prefer_i64 = TCG_TARGET_REG_BITS == 64,
.opt_opc = vecop_list,
.load_dest = true,
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] target/arm: Fix 64-bit SSRA
2023-08-21 2:20 [PATCH] target/arm: Fix 64-bit SSRA Richard Henderson
@ 2023-08-21 3:00 ` Richard Henderson
2023-08-21 6:18 ` Philippe Mathieu-Daudé
2023-08-21 11:56 ` Peter Maydell
2 siblings, 0 replies; 4+ messages in thread
From: Richard Henderson @ 2023-08-21 3:00 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm, qemu-stable
On 8/20/23 19:20, Richard Henderson wrote:
> Typo applied byte-wise shift instead of double-word shift.
>
> Cc: qemu-stable@nongnu.org
> Fixes: 631e565450c ("target/arm: Create gen_gvec_[us]sra")
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1779
Bah. #1737
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/arm/tcg/translate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/arm/tcg/translate.c b/target/arm/tcg/translate.c
> index b71ac2d0d5..39541ecdf0 100644
> --- a/target/arm/tcg/translate.c
> +++ b/target/arm/tcg/translate.c
> @@ -3053,7 +3053,7 @@ void gen_gvec_ssra(unsigned vece, uint32_t rd_ofs, uint32_t rm_ofs,
> .vece = MO_32 },
> { .fni8 = gen_ssra64_i64,
> .fniv = gen_ssra_vec,
> - .fno = gen_helper_gvec_ssra_b,
> + .fno = gen_helper_gvec_ssra_d,
> .prefer_i64 = TCG_TARGET_REG_BITS == 64,
> .opt_opc = vecop_list,
> .load_dest = true,
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] target/arm: Fix 64-bit SSRA
2023-08-21 2:20 [PATCH] target/arm: Fix 64-bit SSRA Richard Henderson
2023-08-21 3:00 ` Richard Henderson
@ 2023-08-21 6:18 ` Philippe Mathieu-Daudé
2023-08-21 11:56 ` Peter Maydell
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-08-21 6:18 UTC (permalink / raw)
To: Richard Henderson, qemu-devel; +Cc: qemu-arm, qemu-stable
On 21/8/23 04:20, Richard Henderson wrote:
> Typo applied byte-wise shift instead of double-word shift.
>
> Cc: qemu-stable@nongnu.org
> Fixes: 631e565450c ("target/arm: Create gen_gvec_[us]sra")
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1779
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/arm/tcg/translate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] target/arm: Fix 64-bit SSRA
2023-08-21 2:20 [PATCH] target/arm: Fix 64-bit SSRA Richard Henderson
2023-08-21 3:00 ` Richard Henderson
2023-08-21 6:18 ` Philippe Mathieu-Daudé
@ 2023-08-21 11:56 ` Peter Maydell
2 siblings, 0 replies; 4+ messages in thread
From: Peter Maydell @ 2023-08-21 11:56 UTC (permalink / raw)
To: Richard Henderson; +Cc: qemu-devel, qemu-arm, qemu-stable
On Mon, 21 Aug 2023 at 03:20, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Typo applied byte-wise shift instead of double-word shift.
>
> Cc: qemu-stable@nongnu.org
> Fixes: 631e565450c ("target/arm: Create gen_gvec_[us]sra")
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1779
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/arm/tcg/translate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to target-arm-for-8.2 with the gitlab URL fixed, thanks.
-- PMM
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-08-21 11:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-21 2:20 [PATCH] target/arm: Fix 64-bit SSRA Richard Henderson
2023-08-21 3:00 ` Richard Henderson
2023-08-21 6:18 ` Philippe Mathieu-Daudé
2023-08-21 11:56 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).