From: Max Reitz <mreitz@redhat.com>
To: Emanuele Giuseppe Esposito <eesposit@redhat.com>, qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH v2] qemu-iotests: fix pylint 2.8 consider-using-with error
Date: Wed, 12 May 2021 19:04:44 +0200 [thread overview]
Message-ID: <d2253d8d-89dd-1acf-e005-0fb3aee6610d@redhat.com> (raw)
In-Reply-To: <20210510190449.65948-1-eesposit@redhat.com>
On 10.05.21 21:04, Emanuele Giuseppe Esposito wrote:
> pylint 2.8 introduces consider-using-with error, suggesting
> to use the 'with' block statement when possible.
>
> Modify all subprocess.Popen call to use the 'with' statement,
> except the one in __init__ of QemuIoInteractive class, since
> it is assigned to a class field and used in other methods.
>
> Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
> ---
> v1 -> v2:
> * fix indentation [Max]
> * explain why we disabled the check in QemuIoInteractive's __init__ [Max]
Thanks!
Applied to my block branch:
https://github.com/XanClic/qemu/commits/block
Max
next prev parent reply other threads:[~2021-05-12 17:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-10 19:04 [PATCH v2] qemu-iotests: fix pylint 2.8 consider-using-with error Emanuele Giuseppe Esposito
2021-05-12 17:04 ` Max Reitz [this message]
2021-05-14 14:09 ` Max Reitz
2021-05-14 14:40 ` Emanuele Giuseppe Esposito
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2253d8d-89dd-1acf-e005-0fb3aee6610d@redhat.com \
--to=mreitz@redhat.com \
--cc=eesposit@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).