From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1ACB2C2D0E4 for ; Tue, 24 Nov 2020 12:11:15 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DAFAA2076B for ; Tue, 24 Nov 2020 12:11:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="a+HSh8DL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DAFAA2076B Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=virtuozzo.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48586 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1khXA8-00046m-QD for qemu-devel@archiver.kernel.org; Tue, 24 Nov 2020 07:11:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:59830) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1khX7h-0002At-Vd; Tue, 24 Nov 2020 07:08:42 -0500 Received: from mail-vi1eur05on2104.outbound.protection.outlook.com ([40.107.21.104]:46561 helo=EUR05-VI1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1khX7e-0006Ea-ME; Tue, 24 Nov 2020 07:08:41 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Af3KqZ+Ty0a68c9QqomtWBEfALpltYWYfScf1Ap9Y5wGq1EaPLZE7KzwIVNdZh6YccXhxLwsknsVuYSFa28H3ZNin7VAmbD1EmZ1T8ZoxfDqYtVNEOy9cuXTgNOXAwwWImMc8L1gmrkY4tTfB3aQXVtWYuxa9gPCAwWaNlGppMskUswpkiQY2bz6h5nMgpOEZdvKGF91ealrK3ckO+dpRR8LPLRLZ58vM94UF3KHKERkBuRNemueD0jIw6YRo90hg6whE9IJ8RhLhEa4XVIhhCijfR4O9CYGS4RsdCcR82rYjxyy6TLbrrlhOJuXWoUUqKnrZhxWkw9miMaQ1qLy1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cQ/bcwLy/Y3GCokaAhuE35xhNOmywMvpzEOcrJ6R2g8=; b=UCwFnSPD9YNiOb8i0RzAyloqdBAiFJ6uh7tR8aKzO809fr2UYVStUFXvSdNc3xgHXFrZYH8Yi7xqUfyKXjbKqlc9e2wyaKCXH4VzjhAn2xXIfLjvMpaDrJr3NnDSLh1nV+5YchTRJGCQoisf26rtHXd51/nDAeM+WGzoC7QGQRn/y6Ps3LWG47iYXWTzDxH6Yt62FufzSN+t2G0IZwM+3aRrm5baLY4ruc6XvYcMbcQr/U8zUgTvoAO9hzdM3JdMD8IN4Vx7AOJ8/C3y4to8nNw+rgtPD6OqO9LyoC9JQjm56EOxfTvXEApZ2GJsF71/F31huiFplr+A5sxLfFSvOA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cQ/bcwLy/Y3GCokaAhuE35xhNOmywMvpzEOcrJ6R2g8=; b=a+HSh8DLUkNAhGfD7yND1++OuaN9EN/SRU6VEgCv7i8WakYD+1Ddp+mhVUa8M+RiYjJUtTBOpF61sUg0wcSDDmvfvxn3mWhshd0ovcx+vaF9nFegLok/SLn8Gx+8fUgdxcvboZbAyG2/r1inKth6KIdaAVWxSwx9MTN4vm3fCW8= Authentication-Results: openvz.org; dkim=none (message not signed) header.d=none;openvz.org; dmarc=none action=none header.from=virtuozzo.com; Received: from HE1PR0801MB2124.eurprd08.prod.outlook.com (2603:10a6:3:89::22) by HE1PR0802MB2411.eurprd08.prod.outlook.com (2603:10a6:3:db::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3589.20; Tue, 24 Nov 2020 12:08:34 +0000 Received: from HE1PR0801MB2124.eurprd08.prod.outlook.com ([fe80::c565:a7d7:a7ab:e9c4]) by HE1PR0801MB2124.eurprd08.prod.outlook.com ([fe80::c565:a7d7:a7ab:e9c4%10]) with mapi id 15.20.3589.030; Tue, 24 Nov 2020 12:08:33 +0000 Subject: Re: [PATCH v2 1/2] iotests: add another bash sleep command to 247 To: Vladimir Sementsov-Ogievskiy , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, marcandre.lureau@redhat.com, pbonzini@redhat.com, kwolf@redhat.com, mreitz@redhat.com, armbru@redhat.com, dgilbert@redhat.com, den@openvz.org References: <1606146274-246154-1-git-send-email-andrey.shinkevich@virtuozzo.com> <1606146274-246154-2-git-send-email-andrey.shinkevich@virtuozzo.com> <7fa343b4-cb87-cb64-956a-87c3a32f75cc@virtuozzo.com> From: Andrey Shinkevich Message-ID: Date: Tue, 24 Nov 2020 15:08:30 +0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 In-Reply-To: <7fa343b4-cb87-cb64-956a-87c3a32f75cc@virtuozzo.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Originating-IP: [109.252.36.39] X-ClientProxiedBy: AM4PR07CA0012.eurprd07.prod.outlook.com (2603:10a6:205:1::25) To HE1PR0801MB2124.eurprd08.prod.outlook.com (2603:10a6:3:89::22) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from Admins-MacBook-Pro.local (109.252.36.39) by AM4PR07CA0012.eurprd07.prod.outlook.com (2603:10a6:205:1::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3611.9 via Frontend Transport; Tue, 24 Nov 2020 12:08:32 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 212dacdb-6428-436b-60aa-08d89071aa3a X-MS-TrafficTypeDiagnostic: HE1PR0802MB2411: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2276; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GS/qKj1i9pKlwRaMoBzj9KmwEyDhyx9HZ28KW7eKI7mEEYicpBaixj8fcvfFRX2sE0gNY+WMTdWsjna6L5qH7RCpkDblnP089LYFsjTAfTelYCGa3A8IlpOgRD6XK5wQQgZY6LKUOO5MZmIJhKxLTh/qbBtzNdxc+J48njCxSCr5INR5MURbtrT/6gQ/yd8KkWWZu4p7K1c9uM0kD1T6Afr5iTWIfHtL/UcT9jIcstBvMYWchG5d9PE3q6WK6kE0CdyJDAgCpOvFta0jF+R4ZShjkK7ifkFxQTKkfybZT+e1Y/ypay9C3EEtP+n87uXSBE+BfKeQlbGDQWpMu1EEXJsDf29r+qU1Jf+orGapTPk79Tc/kh0Ue71l+XEc9tcq X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:HE1PR0801MB2124.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(376002)(396003)(39840400004)(136003)(366004)(2616005)(2906002)(8676002)(956004)(44832011)(107886003)(36756003)(5660300002)(86362001)(66556008)(66476007)(31696002)(66946007)(4326008)(316002)(31686004)(8936002)(26005)(83380400001)(16526019)(186003)(6506007)(6512007)(478600001)(53546011)(52116002)(6486002)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: C52TWcQwFnz9UOha1A46Val3cozDO2rXG/fkRbBlb8s550Oowj65e/mODTdfraDV04F4vT73ZCWJ9YbggAZam2+OgN3yQI/FfNnrw0hVWdETm/kzYuYJHxFuUZEKgEFiK8fRNHSzhBWKzuhD+fHaeFK6weDEaezsSMOoQIER/DAMfCOIVL3kydE1yVF/jXysYNlZgkfw8ipapmNesGqnVzjV5eWcHfpuTdKCVawaTmbN4esEQ/mv3dtMNvBQeHkBA5Y9Vf+tyBkgFvE8mgdJA7t40xKWP8xPtLULj01t7U1lowADvbaln1RG8hGO+hdGam9qDc6ir6+reRZ1ukbuJbFGM/YrdlWOpBQeMf7cYOgFYhrqpTYR/XQqKNPN9CDAcitv3M7QXttAahWiRqaTwoPetZJW+4Xehb6J7A33l0Wf8No5/na7WzujakyyKKIOx/WdtLX2SAJC42jWZLhk3E6wjyx3rKBcLGrHQHLTTAxaTQZJGeCXUoJOvjmHPeTbWYhX6K/SGoe/9zEOzDEn+FG0XqMzK8fbiVuIY5JOO7x7M2uMNmbzsoKL2QDYYi8QE1N3qOsAOOkhyt/7ia1+5gHfFFheo5NtlpI6UDrSxbz21ML+unOj0/cUP+HIcFLXudDPbXG7YvgQZvgGYehRk88QqiNhrVjk/D2iftXd7j+sgPDYf7/hWANUhl17Mra9rf66lBvdRz76HM5mOm0k3ve42b5SwWIA8FLxiCAp2Ylw3PqZLZVwyfz7f/qofmIUK0WS2K4h5rQAl4WcUjHOLdjZXOIggbc1X5VhDh3ZSk2+l2L5K0OKlgOfH6zMRFRk0mdDfURd/5iXmd3PLxRt/fmA+4V2EgNEAdz/sgChpTWf5xh7nUr6g52pdDC/sN7H95gepqHiATLhfpJ0URy5Kw== X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 212dacdb-6428-436b-60aa-08d89071aa3a X-MS-Exchange-CrossTenant-AuthSource: HE1PR0801MB2124.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Nov 2020 12:08:33.7250 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: J0dKIhbpXAjFzvw1kKDTbqoGF/46cdaQVKyT+258wYZnxPY4caVdKNMZ3hXsHIA5PCJKCSnqK5U44S4xk8b+MZsZQ9eBlA4Gvo/ZSbp5jq4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0802MB2411 Received-SPF: pass client-ip=40.107.21.104; envelope-from=andrey.shinkevich@virtuozzo.com; helo=EUR05-VI1-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MSGID_FROM_MTA_HEADER=0.001, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 24.11.2020 13:04, Vladimir Sementsov-Ogievskiy wrote: > 23.11.2020 18:44, Andrey Shinkevich wrote: >> This patch paves the way for the one that follows. The following patch >> makes the QMP monitor to read up to 4K from stdin at once. That results >> in running the bash 'sleep' command before the _qemu_proc_exec() starts > > But how? Before _qemu_proc_exec() starts, qemu monitor is not runnning, > and its new behavior can't influence.. > I am not a bash expert to explain 'how' but this workaround works. It's just a test. Maybe other colleagues can say. > If bash subshell work in unpredictable way, may be better is refactor test > to send commands one by one with help of _send_qemu_cmd. Then sleep will > be natively executed between sending commands. > Or maybe write a similar test case in Python if Kevin agrees. >> in subshell. Another 'sleep' command with an unobtrusive 'query-status' >> plays as a workaround. >> >> Signed-off-by: Andrey Shinkevich >> --- >>   tests/qemu-iotests/247     | 2 ++ >>   tests/qemu-iotests/247.out | 1 + >>   2 files changed, 3 insertions(+) >> >> diff --git a/tests/qemu-iotests/247 b/tests/qemu-iotests/247 >> index 87e37b3..7d316ec 100755 >> --- a/tests/qemu-iotests/247 >> +++ b/tests/qemu-iotests/247 >> @@ -59,6 +59,8 @@ TEST_IMG="$TEST_IMG.4" _make_test_img $size >>   {"execute":"block-commit", >>    "arguments":{"device":"format-4", "top-node": "format-2", >> "base-node":"format-0", "job-id":"job0"}} >>   EOF >> +sleep 1 >> +echo '{"execute":"query-status"}' >>   if [ "${VALGRIND_QEMU}" == "y" ]; then >>       sleep 10 >>   else >> diff --git a/tests/qemu-iotests/247.out b/tests/qemu-iotests/247.out >> index e909e83..13d9547 100644 >> --- a/tests/qemu-iotests/247.out >> +++ b/tests/qemu-iotests/247.out >> @@ -17,6 +17,7 @@ QMP_VERSION >>   {"timestamp": {"seconds":  TIMESTAMP, "microseconds":  TIMESTAMP}, >> "event": "BLOCK_JOB_COMPLETED", "data": {"device": "job0", "len": >> 134217728, "offset": 134217728, "speed": 0, "type": "commit"}} >>   {"timestamp": {"seconds":  TIMESTAMP, "microseconds":  TIMESTAMP}, >> "event": "JOB_STATUS_CHANGE", "data": {"status": "concluded", "id": >> "job0"}} >>   {"timestamp": {"seconds":  TIMESTAMP, "microseconds":  TIMESTAMP}, >> "event": "JOB_STATUS_CHANGE", "data": {"status": "null", "id": "job0"}} >> +{"return": {"status": "running", "singlestep": false, "running": true}} >>   {"return": {}} >>   {"timestamp": {"seconds":  TIMESTAMP, "microseconds":  TIMESTAMP}, >> "event": "SHUTDOWN", "data": {"guest": false, "reason": "host-qmp-quit"}} >>   *** done >> > >