From: Thomas Huth <thuth@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Markus Armbruster" <armbru@redhat.com>,
"Fam Zheng" <famz@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@gmail.com>
Subject: Re: [Qemu-devel] [PATCH v2 1/5] checkpatch: add a --strict check for utf-8 in commit logs
Date: Wed, 2 May 2018 07:32:12 +0200 [thread overview]
Message-ID: <d2369182-bce5-0af2-d33d-b2450b943ad2@redhat.com> (raw)
In-Reply-To: <20180430124651.10340-2-stefanha@redhat.com>
On 30.04.2018 14:46, Stefan Hajnoczi wrote:
> From: Joe Perches <joe@perches.com>
>
> Some find using utf-8 in commit logs inappropriate.
>
> Some patch commit logs contain unintended utf-8 characters when doing
> things like copy/pasting compilation output.
>
> Look for the start of any commit log by skipping initial lines that look
> like email headers and "From: " lines.
>
> Stop looking for utf-8 at the first signature line.
>
> Signed-off-by: Joe Perches <joe@perches.com>
> Suggested-by: Andrew Morton <akpm@linux-foundation.org>
> Cc: Andy Whitcroft <apw@shadowen.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
> (cherry picked from commit 15662b3e8644905032c2e26808401a487d4e90c1)
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
>
> Conflicts:
> QEMU does not have CHK(), use WARN() instead.
>
> QEMU WARN() only takes one argument, drop the 'type' value in the
> first argument.
> ---
> scripts/checkpatch.pl | 30 ++++++++++++++++++++++++++----
> 1 file changed, 26 insertions(+), 4 deletions(-)
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2018-05-02 5:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-30 12:46 [Qemu-devel] [PATCH v2 0/5] checkpatch: backport UTF-8 fixes and MAINTAINERS check Stefan Hajnoczi
2018-04-30 12:46 ` [Qemu-devel] [PATCH v2 1/5] checkpatch: add a --strict check for utf-8 in commit logs Stefan Hajnoczi
2018-05-02 5:32 ` Thomas Huth [this message]
2018-04-30 12:46 ` [Qemu-devel] [PATCH v2 2/5] checkpatch: check utf-8 content from a commit log when it's missing from charset Stefan Hajnoczi
2018-04-30 12:46 ` [Qemu-devel] [PATCH v2 3/5] checkpatch: ignore email headers better Stefan Hajnoczi
2018-04-30 12:46 ` [Qemu-devel] [PATCH v2 4/5] checkpatch: emit a warning on file add/move/delete Stefan Hajnoczi
2018-04-30 12:46 ` [Qemu-devel] [PATCH v2 5/5] checkpatch: reduce MAINTAINERS update message frequency Stefan Hajnoczi
2018-04-30 12:56 ` [Qemu-devel] [PATCH v2 0/5] checkpatch: backport UTF-8 fixes and MAINTAINERS check no-reply
2018-05-01 13:04 ` Stefan Hajnoczi
2018-05-02 5:23 ` Thomas Huth
2018-05-03 6:21 ` Fam Zheng
2018-05-02 16:50 ` Markus Armbruster
2018-05-10 9:42 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2369182-bce5-0af2-d33d-b2450b943ad2@redhat.com \
--to=thuth@redhat.com \
--cc=armbru@redhat.com \
--cc=famz@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).