From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95BB7C432C1 for ; Tue, 24 Sep 2019 19:59:50 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 67BDE2146E for ; Tue, 24 Sep 2019 19:59:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 67BDE2146E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50400 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iCqyT-0001kt-Fv for qemu-devel@archiver.kernel.org; Tue, 24 Sep 2019 15:59:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36116) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iCqof-0000AI-Ry for qemu-devel@nongnu.org; Tue, 24 Sep 2019 15:49:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iCqod-00081j-Ku for qemu-devel@nongnu.org; Tue, 24 Sep 2019 15:49:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48818) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iCqod-00081O-5u for qemu-devel@nongnu.org; Tue, 24 Sep 2019 15:49:39 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 840F2308AA12; Tue, 24 Sep 2019 19:12:35 +0000 (UTC) Received: from [10.3.116.249] (ovpn-116-249.phx2.redhat.com [10.3.116.249]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6095D5D713; Tue, 24 Sep 2019 19:12:27 +0000 (UTC) Subject: Re: [PATCH 03/25] qapi: New QAPISourceInfo, replacing dict To: Markus Armbruster , qemu-devel@nongnu.org References: <20190924132830.15835-1-armbru@redhat.com> <20190924132830.15835-4-armbru@redhat.com> From: Eric Blake Openpgp: preference=signencrypt Autocrypt: addr=eblake@redhat.com; keydata= xsBNBEvHyWwBCACw7DwsQIh0kAbUXyqhfiKAKOTVu6OiMGffw2w90Ggrp4bdVKmCaEXlrVLU xphBM8mb+wsFkU+pq9YR621WXo9REYVIl0FxKeQo9dyQBZ/XvmUMka4NOmHtFg74nvkpJFCD TUNzmqfcjdKhfFV0d7P/ixKQeZr2WP1xMcjmAQY5YvQ2lUoHP43m8TtpB1LkjyYBCodd+LkV GmCx2Bop1LSblbvbrOm2bKpZdBPjncRNob73eTpIXEutvEaHH72LzpzksfcKM+M18cyRH+nP sAd98xIbVjm3Jm4k4d5oQyE2HwOur+trk2EcxTgdp17QapuWPwMfhaNq3runaX7x34zhABEB AAHNHkVyaWMgQmxha2UgPGVibGFrZUByZWRoYXQuY29tPsLAegQTAQgAJAIbAwULCQgHAwUV CgkICwUWAgMBAAIeAQIXgAUCS8fL9QIZAQAKCRCnoWtKJSdDahBHCACbl/5FGkUqJ89GAjeX RjpAeJtdKhujir0iS4CMSIng7fCiGZ0fNJCpL5RpViSo03Q7l37ss+No+dJI8KtAp6ID+PMz wTJe5Egtv/KGUKSDvOLYJ9WIIbftEObekP+GBpWP2+KbpADsc7EsNd70sYxExD3liwVJYqLc Rw7so1PEIFp+Ni9A1DrBR5NaJBnno2PHzHPTS9nmZVYm/4I32qkLXOcdX0XElO8VPDoVobG6 gELf4v/vIImdmxLh/w5WctUpBhWWIfQDvSOW2VZDOihm7pzhQodr3QP/GDLfpK6wI7exeu3P pfPtqwa06s1pae3ad13mZGzkBdNKs1HEm8x6zsBNBEvHyWwBCADGkMFzFjmmyqAEn5D+Mt4P zPdO8NatsDw8Qit3Rmzu+kUygxyYbz52ZO40WUu7EgQ5kDTOeRPnTOd7awWDQcl1gGBXgrkR pAlQ0l0ReO57Q0eglFydLMi5bkwYhfY+TwDPMh3aOP5qBXkm4qIYSsxb8A+i00P72AqFb9Q7 3weG/flxSPApLYQE5qWGSXjOkXJv42NGS6o6gd4RmD6Ap5e8ACo1lSMPfTpGzXlt4aRkBfvb NCfNsQikLZzFYDLbQgKBA33BDeV6vNJ9Cj0SgEGOkYyed4I6AbU0kIy1hHAm1r6+sAnEdIKj cHi3xWH/UPrZW5flM8Kqo14OTDkI9EtlABEBAAHCwF8EGAEIAAkFAkvHyWwCGwwACgkQp6Fr SiUnQ2q03wgAmRFGDeXzc58NX0NrDijUu0zx3Lns/qZ9VrkSWbNZBFjpWKaeL1fdVeE4TDGm I5mRRIsStjQzc2R9b+2VBUhlAqY1nAiBDv0Qnt+9cLiuEICeUwlyl42YdwpmY0ELcy5+u6wz mK/jxrYOpzXKDwLq5k4X+hmGuSNWWAN3gHiJqmJZPkhFPUIozZUCeEc76pS/IUN72NfprZmF Dp6/QDjDFtfS39bHSWXKVZUbqaMPqlj/z6Ugk027/3GUjHHr8WkeL1ezWepYDY7WSoXwfoAL 2UXYsMAr/uUncSKlfjvArhsej0S4zbqim2ZY6S8aRWw94J3bSvJR+Nwbs34GPTD4Pg== Organization: Red Hat, Inc. Message-ID: Date: Tue, 24 Sep 2019 14:12:27 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190924132830.15835-4-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qgC1pTuMZDo3QihgvYdM10DCygcPh9D8l" X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Tue, 24 Sep 2019 19:12:42 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: marcandre.lureau@redhat.com, mdroth@linux.vnet.ibm.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --qgC1pTuMZDo3QihgvYdM10DCygcPh9D8l Content-Type: multipart/mixed; boundary="vlB29tc8zbW2BXTVCd2IarIJqEHipSMxr"; protected-headers="v1" From: Eric Blake To: Markus Armbruster , qemu-devel@nongnu.org Cc: mdroth@linux.vnet.ibm.com, marcandre.lureau@redhat.com Message-ID: Subject: Re: [PATCH 03/25] qapi: New QAPISourceInfo, replacing dict References: <20190924132830.15835-1-armbru@redhat.com> <20190924132830.15835-4-armbru@redhat.com> In-Reply-To: <20190924132830.15835-4-armbru@redhat.com> --vlB29tc8zbW2BXTVCd2IarIJqEHipSMxr Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 9/24/19 8:28 AM, Markus Armbruster wrote: > We track source locations with a dict of the form >=20 > {'file': FNAME, 'line': LINENO, parent': PARENT} >=20 > where PARENT is None for the main file, and the include directive's > source location for included files. >=20 > This is servicable enough, but the next commit will add information, > and that's going to come out cleaner if we turn this into a class. So > do that. >=20 > Signed-off-by: Markus Armbruster > --- > class QAPIError(Exception): > - def __init__(self, fname, line, col, incl_info, msg): > + def __init__(self, info, col, msg): > Exception.__init__(self) Unrelated to this patch, but I just noticed https://docs.quantifiedcode.com/python-anti-patterns/ today (in part based on my question on another patch about using 'list.get(key, False)' rather than 'key in list and list[key]'). In particular, I found https://docs.quantifiedcode.com/python-anti-patterns/correctness/missing_= argument_to_super.html which recommends using: def __init__(...): super(QAPIError, self).__init__() (because of Python 2), while other sits state that with python 3, you can further get away with: def __init__(...): super().__init(...) Should we be switching our code base to use super() in more places, rather than hard-coding the parent class name? --=20 Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org --vlB29tc8zbW2BXTVCd2IarIJqEHipSMxr-- --qgC1pTuMZDo3QihgvYdM10DCygcPh9D8l Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEccLMIrHEYCkn0vOqp6FrSiUnQ2oFAl2KapsACgkQp6FrSiUn Q2oTUAf/bgbjrmpfhO42abfj7siWc7pI4zJ4vtuSah0bsrUIlyJGPk+6ESEgLIB3 YTj1b2gVGsUvvEsfJJIAVKx8TfbSzJlZ2uGMB3Y/MOT7LOfP+f4NbQM4OFFGE4IM RF4N0xSp+JxkMdtKSwIIS2BsARPyc9IwImoVr0+WJZjT4MF9Y3KklrvkuyXy3ZAF QvRP1mhGDbY3Xd+AnEaBnbObBfbkZxA9N8cdHOnBQBSNJcEMuDWQCclFzd0elQ/x 98aOYS0fzEN17LT315kOmVkJyhr5kk6T7cKOas7EKkO5ZZhSXNUYJddNu5GQCC6t RI/CPoGbKTfr4zkY7wBBcLbWP+kTTA== =lzOF -----END PGP SIGNATURE----- --qgC1pTuMZDo3QihgvYdM10DCygcPh9D8l--