From: Paolo Bonzini <pbonzini@redhat.com>
To: Lin Ma <lma@suse.com>, qemu-devel@nongnu.org
Cc: famz@redhat.com, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 RESEND] Makefile: Fix owner and group for qemu-version.h.tmp
Date: Mon, 13 Feb 2017 11:07:00 +0100 [thread overview]
Message-ID: <d244306c-36df-bb23-3dad-6706545e2476@redhat.com> (raw)
In-Reply-To: <20170213095148.25500-1-lma@suse.com>
On 13/02/2017 10:51, Lin Ma wrote:
> By commit 67a1de0d, When we perform 'git pull && make && sudo make install',
> In 'make' stage a qemu-version.h.tmp will be generated. If the content of
> qemu-version.h.tmp and qemu-version.h aren't consistent, The qemu-version.h.tmp
> will be renamed to qemu-version.h. Because of the target FORCE, The same action
> will be do again in 'make install' stage.
But why does the content of .h and .h.tmp not match during "make install"?
Paolo
> diff --git a/Makefile b/Makefile
> index 1a8bfb2..1ca45b2 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -184,7 +184,7 @@ qemu-version.h: FORCE
> printf '""\n'; \
> fi; \
> fi) > $@.tmp)
> - $(call quiet-command, cmp -s $@ $@.tmp || mv $@.tmp $@)
> + $(call quiet-command, cmp -s $@ $@.tmp || cp $@.tmp $@)
next prev parent reply other threads:[~2017-02-13 10:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-13 9:51 [Qemu-devel] [PATCH v2 RESEND] Makefile: Fix owner and group for qemu-version.h.tmp Lin Ma
2017-02-13 10:07 ` Paolo Bonzini [this message]
2017-02-13 11:53 ` [Qemu-devel] 答复： " Lin Ma
2017-02-13 11:55 ` Paolo Bonzini
2017-02-14 7:18 ` Lin Ma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d244306c-36df-bb23-3dad-6706545e2476@redhat.com \
--to=pbonzini@redhat.com \
--cc=famz@redhat.com \
--cc=lma@suse.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).