qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: Daniel Henrique Barboza <danielhb413@gmail.com>,
	BALATON Zoltan <balaton@eik.bme.hu>,
	qemu-devel@nongnu.org, qemu-ppc@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>,
	Bernhard Beschow <shentey@gmail.com>,
	Peter Maydell <peter.maydell@linaro.org>,
	philmd@linaro.org, ReneEngel80@emailn.de,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v9 2/7] hw/intc/i8259: Implement legacy LTIM Edge/Level Bank Select
Date: Tue, 07 Mar 2023 13:39:33 +0000	[thread overview]
Message-ID: <d24b46ee8fba84f9c7a7d8b8f66d07cc60516989.camel@infradead.org> (raw)
In-Reply-To: <10178ae9-e306-0885-a14a-20fc651a8494@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 465 bytes --]

On Tue, 2023-03-07 at 10:36 -0300, Daniel Henrique Barboza wrote:
> 
> Checkpatch will nag about it claiming that we need spaces between
> '*'. The maintainer can fix it in-tree though.

I saw that and explicitly didn't care. 3/5 of the existing examples
within the tree look like that one — which is how the docs tell us to
do it — so I figured checkpatch could just be sad.

> Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>

Thanks.

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5965 bytes --]

  parent reply	other threads:[~2023-03-07 13:40 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-07 11:42 [PATCH v9 0/7] Pegasos2 fixes and audio output support BALATON Zoltan
2023-03-07 11:42 ` [PATCH v9 1/7] hw/display/sm501: Add debug property to control pixman usage BALATON Zoltan
2023-03-07 15:11   ` Philippe Mathieu-Daudé
2023-03-07 15:15     ` BALATON Zoltan
2023-03-07 11:42 ` [PATCH v9 2/7] hw/intc/i8259: Implement legacy LTIM Edge/Level Bank Select BALATON Zoltan
2023-03-07 13:36   ` Daniel Henrique Barboza
2023-03-07 13:38     ` Peter Maydell
2023-03-07 13:39     ` David Woodhouse [this message]
2023-03-07 14:45       ` Daniel Henrique Barboza
2023-03-07 14:18     ` BALATON Zoltan
2023-03-07 11:42 ` [PATCH v9 3/7] Revert "hw/isa/vt82c686: Remove intermediate IRQ forwarder" BALATON Zoltan
2023-03-07 13:37   ` Daniel Henrique Barboza
2023-03-07 11:42 ` [PATCH v9 4/7] hw/isa/vt82c686: Implement PCI IRQ routing BALATON Zoltan
2023-10-30  4:05   ` Philippe Mathieu-Daudé
2023-10-30  9:02     ` BALATON Zoltan
2023-10-30  9:22       ` BALATON Zoltan
2023-10-30  9:26       ` Philippe Mathieu-Daudé
2023-03-07 11:42 ` [PATCH v9 5/7] hw/ppc/pegasos2: Fix PCI interrupt routing BALATON Zoltan
2023-03-07 11:42 ` [PATCH v9 6/7] hw/usb/vt82c686-uhci-pci: Use PCI IRQ routing BALATON Zoltan
2023-03-07 11:42 ` [PATCH v9 7/7] hw/audio/via-ac97: Basic implementation of audio playback BALATON Zoltan
2023-03-07 16:20 ` [PATCH v9 0/7] Pegasos2 fixes and audio output support Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d24b46ee8fba84f9c7a7d8b8f66d07cc60516989.camel@infradead.org \
    --to=dwmw2@infradead.org \
    --cc=ReneEngel80@emailn.de \
    --cc=balaton@eik.bme.hu \
    --cc=danielhb413@gmail.com \
    --cc=kraxel@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=shentey@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).