From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Albert Esteve <aesteve@redhat.com>
Cc: qemu-devel@nongnu.org, Fam Zheng <fam@euphon.net>,
"Michael S. Tsirkin" <mst@redhat.com>,
cohuck@redhat.com, kraxel@redhat.com, marcandre.lureau@gmail.com
Subject: Re: [PATCH v6 3/3] vhost-user: add shared_object msg
Date: Wed, 6 Sep 2023 16:43:39 +0200 [thread overview]
Message-ID: <d256b040-d151-05a5-2654-d3b951074984@linaro.org> (raw)
In-Reply-To: <CADSE00Lv7ry403fE573dRv1xdz_-UEgoj1CA6OABXeXnndoP8g@mail.gmail.com>
On 6/9/23 16:33, Albert Esteve wrote:
> I note you ignored my comment regarding adding a 'Error **' argument in
> the previous version:
> https://lore.kernel.org/qemu-devel/911eef0c-d04f-2fcf-e78b-2475cd7af8f0@linaro.org/ <https://lore.kernel.org/qemu-devel/911eef0c-d04f-2fcf-e78b-2475cd7af8f0@linaro.org/>
>
> Sorry I missed those comments somehow :/
Ah, I see.
> I'll check them and resend.
You can also object to them, explaining why this isn't really
useful, if you think so. But first read the big comment in
include/qapi/error.h.
Thanks,
Phil.
next prev parent reply other threads:[~2023-09-06 14:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-06 11:15 [PATCH v6 0/3] Virtio shared dma-buf Albert Esteve
2023-09-06 11:15 ` [PATCH v6 1/3] uuid: add a hash function Albert Esteve
2023-09-06 11:15 ` [PATCH v6 2/3] virtio-dmabuf: introduce virtio-dmabuf Albert Esteve
2023-09-06 12:03 ` Albert Esteve
2023-09-06 14:21 ` Philippe Mathieu-Daudé
2023-09-06 15:34 ` Albert Esteve
2023-09-06 11:15 ` [PATCH v6 3/3] vhost-user: add shared_object msg Albert Esteve
2023-09-06 14:27 ` Philippe Mathieu-Daudé
2023-09-06 14:33 ` Albert Esteve
2023-09-06 14:43 ` Philippe Mathieu-Daudé [this message]
2023-09-06 16:01 ` Albert Esteve
2023-09-06 16:18 ` Albert Esteve
2023-09-07 6:19 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d256b040-d151-05a5-2654-d3b951074984@linaro.org \
--to=philmd@linaro.org \
--cc=aesteve@redhat.com \
--cc=cohuck@redhat.com \
--cc=fam@euphon.net \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).