qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Daniele Buono <dbuono@linux.vnet.ibm.com>
To: "Paolo Bonzini" <pbonzini@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH] meson: Stop if cfi is enabled with system slirp
Date: Mon, 8 Mar 2021 10:05:45 -0500	[thread overview]
Message-ID: <d25da3e9-215a-d764-ba52-3f13f42f22e2@linux.vnet.ibm.com> (raw)
In-Reply-To: <de675aaa-0cff-e953-58da-cb0a86daa984@redhat.com>

On 3/5/2021 12:18 PM, Paolo Bonzini wrote:
>>
> 
> Ok, so let's go with your patch for now.  Independently we could change 
> libslirp to:
> 
> - add a separate callback (timer_new_v2?) in SlirpCb.  If it is set, we 
> use it and pass an enum instead of the SlirpTimerCb cb.
> 
> - add a function slirp_timer_expired(enum SlirpTimerId timer_id, void 
> *cb_opaque) that does the indirection but without passing around an 
> arbitrary function pointer.
> 
> In 6.1 we will update the internal libslirp to a version that supports 
> the new API, through a patch very similar to mine above.  By requiring 
> that new version as the minimum supported one, enabling CFI will be 
> possible even with system slirp.
> 
> You can open a slirp merge request at 
> https://gitlab.freedesktop.org/slirp/libslirp.

Hi Paolo,
sounds like a good plan!

I'll start working on this.

Regards,
Daniele


  reply	other threads:[~2021-03-08 15:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-04  2:59 [PATCH] meson: Stop if cfi is enabled with system slirp Daniele Buono
2021-03-04 10:37 ` Daniel P. Berrangé
2021-03-04 10:56   ` Paolo Bonzini
2021-03-05 16:52     ` Daniele Buono
2021-03-05 17:18       ` Paolo Bonzini
2021-03-08 15:05         ` Daniele Buono [this message]
2021-03-05 16:53   ` Daniele Buono
2021-03-08 11:19     ` Daniel P. Berrangé
2021-03-08 11:27       ` Paolo Bonzini
2021-03-08 14:58       ` Daniele Buono

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d25da3e9-215a-d764-ba52-3f13f42f22e2@linux.vnet.ibm.com \
    --to=dbuono@linux.vnet.ibm.com \
    --cc=berrange@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).