From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Jiaxun Yang <jiaxun.yang@flygoat.com>
Subject: Re: [PATCH] hw/mips/malta: Fix minor dead code issue
Date: Thu, 6 Apr 2023 17:54:15 +0200 [thread overview]
Message-ID: <d26a0128-10b5-0dae-cf12-15072a564396@linaro.org> (raw)
In-Reply-To: <20230406153721.3349647-1-peter.maydell@linaro.org>
On 6/4/23 17:37, Peter Maydell wrote:
> Coverity points out (in CID 1508390) that write_bootloader has
> some dead code, where we assign to 'p' and then in the following
> line assign to it again. This happened as a result of the
> refactoring in commit cd5066f8618b.
>
> Fix the dead code by removing the 'void *v' variable entirely and
> instead adding a cast when calling bl_setup_gt64120_jump_kernel(), as
> we do at its other callsite in write_bootloader_nanomips().
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> hw/mips/malta.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Thank you!
next prev parent reply other threads:[~2023-04-06 15:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-06 15:37 [PATCH] hw/mips/malta: Fix minor dead code issue Peter Maydell
2023-04-06 15:54 ` Philippe Mathieu-Daudé [this message]
2023-05-09 13:07 ` Peter Maydell
2023-05-09 15:37 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d26a0128-10b5-0dae-cf12-15072a564396@linaro.org \
--to=philmd@linaro.org \
--cc=jiaxun.yang@flygoat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).