qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
	"Cleber Rosa" <crosa@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"John Snow" <jsnow@redhat.com>,
	"Laurent Vivier" <lvivier@redhat.com>
Subject: Re: [PATCH 1/6] qtest: bump min meson timeout to 60 seconds
Date: Thu, 1 Jun 2023 20:38:41 +0200	[thread overview]
Message-ID: <d27a47d6-9ec0-fc70-b7fd-761521d7fa86@redhat.com> (raw)
In-Reply-To: <20230601163123.1805282-2-berrange@redhat.com>

On 01/06/2023 18.31, Daniel P. Berrangé wrote:
> Even some of the relatively fast qtests can sometimes hit the 30 second
> timeout in GitLab CI under high parallelism/load conditions. Bump the
> min to 60 seconds to give a higher margin for reliability.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>   tests/qtest/meson.build | 9 ++-------
>   1 file changed, 2 insertions(+), 7 deletions(-)
> 
> diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build
> index 087f2dc9d7..18d046b53c 100644
> --- a/tests/qtest/meson.build
> +++ b/tests/qtest/meson.build
> @@ -1,12 +1,7 @@
>   slow_qtests = {
> -  'ahci-test' : 60,
>     'bios-tables-test' : 120,
> -  'boot-serial-test' : 60,
>     'migration-test' : 150,
>     'npcm7xx_pwm-test': 150,
> -  'prom-env-test' : 60,
> -  'pxe-test' : 60,
> -  'qos-test' : 60,
>     'qom-test' : 300,
>     'test-hmp' : 120,
>   }
> @@ -373,8 +368,8 @@ foreach dir : target_dirs
>            env: qtest_env,
>            args: ['--tap', '-k'],
>            protocol: 'tap',
> -         timeout: slow_qtests.get(test, 30),
> -         priority: slow_qtests.get(test, 30),
> +         timeout: slow_qtests.get(test, 60),
> +         priority: slow_qtests.get(test, 60),
>            suite: ['qtest', 'qtest-' + target_base])
>     endforeach
>   endforeach

Reviewed-by: Thomas Huth <thuth@redhat.com>



  reply	other threads:[~2023-06-01 18:39 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-01 16:31 [PATCH 0/6] tests: enable meson test timeouts to improve debuggability Daniel P. Berrangé
2023-06-01 16:31 ` [PATCH 1/6] qtest: bump min meson timeout to 60 seconds Daniel P. Berrangé
2023-06-01 18:38   ` Thomas Huth [this message]
2023-06-01 16:31 ` [PATCH 2/6] qtest: bump migration-test timeout to 5 minutes Daniel P. Berrangé
2023-06-01 18:39   ` Thomas Huth
2023-06-01 16:31 ` [PATCH 3/6] qtest: bump qom-test timeout to 7 minutes Daniel P. Berrangé
2023-06-01 19:07   ` Thomas Huth
2023-06-01 16:31 ` [PATCH 4/6] qtest: bump aspeed_smc-test timeout to 2 minutes Daniel P. Berrangé
2023-06-01 19:07   ` Thomas Huth
2023-06-05 11:31   ` Thomas Huth
2023-06-05 11:48     ` Daniel P. Berrangé
2023-06-01 16:31 ` [PATCH 5/6] qtest: bump bios-table-test timeout to 6 minutes Daniel P. Berrangé
2023-06-01 19:10   ` Thomas Huth
2023-06-05 11:37   ` Thomas Huth
2023-06-05 11:49     ` Daniel P. Berrangé
2023-06-01 16:31 ` [PATCH 6/6] mtest2make: stop disabling meson test timeouts Daniel P. Berrangé
2023-06-01 19:15   ` Thomas Huth
2023-06-01 18:44 ` [PATCH 0/6] tests: enable meson test timeouts to improve debuggability Richard Henderson
2023-06-05 14:07 ` Thomas Huth
2023-06-05 14:14   ` Daniel P. Berrangé
2023-06-05 15:36     ` Thomas Huth
2023-06-05 15:45   ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d27a47d6-9ec0-fc70-b7fd-761521d7fa86@redhat.com \
    --to=thuth@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=berrange@redhat.com \
    --cc=crosa@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).