From: Richard Henderson <richard.henderson@linaro.org>
To: Daniel Henrique Barboza <dbarboza@ventanamicro.com>,
qemu-devel@nongnu.org
Cc: qemu-riscv@nongnu.org, alistair.francis@wdc.com,
bmeng@tinylab.org, liweiwei@iscas.ac.cn,
zhiwei_liu@linux.alibaba.com
Subject: Re: [PATCH v7 1/4] tcg: add 'size' param to probe_access_flags()
Date: Thu, 23 Feb 2023 14:23:35 -1000 [thread overview]
Message-ID: <d27b10d7-a98e-0f81-6e63-ee13cdcbaff5@linaro.org> (raw)
In-Reply-To: <78a0f5a5-c2da-c016-1f15-981cf80bf676@linaro.org>
On 2/23/23 14:19, Richard Henderson wrote:
> On 2/23/23 13:44, Daniel Henrique Barboza wrote:
>> + if (unlikely(flags & TLB_NOTDIRTY)) {
>> + notdirty_write(env_cpu(env), addr, 1, full, retaddr);
>
> That '1' should be 'size'. Fixed locally.
Hmph, well, that matches the interface, but it's only used to figure out how many pages to
process, so any len that doesn't cross a page boundary (which we have checked) is equal
bar the tracepoint.
r~
next prev parent reply other threads:[~2023-02-24 0:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-23 23:44 [PATCH v7 0/4] riscv: Add support for Zicbo[m,z,p] instructions Daniel Henrique Barboza
2023-02-23 23:44 ` [PATCH v7 1/4] tcg: add 'size' param to probe_access_flags() Daniel Henrique Barboza
2023-02-24 0:06 ` Richard Henderson
2023-02-24 0:10 ` Richard Henderson
2023-03-01 21:35 ` Palmer Dabbelt
2023-02-24 0:19 ` Richard Henderson
2023-02-24 0:23 ` Richard Henderson [this message]
2023-02-24 9:20 ` Daniel Henrique Barboza
2023-02-23 23:44 ` [PATCH v7 2/4] target/riscv: implement Zicboz extension Daniel Henrique Barboza
2023-02-24 0:06 ` Richard Henderson
2023-02-24 1:48 ` liweiwei
2023-02-23 23:44 ` [PATCH v7 3/4] target/riscv: implement Zicbom extension Daniel Henrique Barboza
2023-02-24 0:07 ` Richard Henderson
2023-02-24 2:01 ` liweiwei
2023-02-23 23:44 ` [PATCH v7 4/4] target/riscv: add Zicbop cbo.prefetch{i, r, m} placeholder Daniel Henrique Barboza
2023-02-24 2:03 ` liweiwei
2023-03-01 21:35 ` [PATCH v7 0/4] riscv: Add support for Zicbo[m,z,p] instructions Palmer Dabbelt
2023-03-01 21:44 ` Daniel Henrique Barboza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d27b10d7-a98e-0f81-6e63-ee13cdcbaff5@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=bmeng@tinylab.org \
--cc=dbarboza@ventanamicro.com \
--cc=liweiwei@iscas.ac.cn \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).