From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A6321C61DA4 for ; Fri, 24 Feb 2023 00:24:34 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pVLsJ-0005bT-34; Thu, 23 Feb 2023 19:23:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVLsH-0005b5-Gg for qemu-devel@nongnu.org; Thu, 23 Feb 2023 19:23:45 -0500 Received: from mail-pj1-x1036.google.com ([2607:f8b0:4864:20::1036]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pVLsE-0000QH-QM for qemu-devel@nongnu.org; Thu, 23 Feb 2023 19:23:45 -0500 Received: by mail-pj1-x1036.google.com with SMTP id z20-20020a17090a8b9400b002372d7f823eso1072945pjn.4 for ; Thu, 23 Feb 2023 16:23:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kfKaE4zgkzHPvaVz7ODj7i+YDgaWj7UxLNCOcc9yQ5Y=; b=r60otlMEIYbQ6v9sFu+PDkwHwbpq/KJjphZ/ydWS5aaCTPm6ZE5gTkXcDNwmyfAuL0 3M8YIYPB+HMfuVY5o+6KBh9kXcF+cWnOa6UH0ux0fhiSX/M4VPiLiCqrih5gaZ4cM5sO cqzaCAtBpcsuXz2aWiXwqn7JnWm/wMXrd58EHTANPivqe3PU5pqhIa6eiSaYHsUhPRe8 P5o5oOafKKuEolsfuNQ4SqNVttuw1YvzhiNHc7KuYTY61OTubxxHFosbmVUFjMyITqrH lIL8eDNchXL9lyU+T54Z8VuW0uLTXsDkwPbTmfwOMB2tzD5Nj8mcWkzQvbgqMiiZIcDg SxBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kfKaE4zgkzHPvaVz7ODj7i+YDgaWj7UxLNCOcc9yQ5Y=; b=L8WHiCDZLMQ5b7Kv34HXraFTTfGUQ802OhcH/X16N0PtlCQJFxzbvLQwB3MTsCgXEY oreOt+Muqz+QLtm1sc9wj0Bn/d92S2TJJDJNyY8U1Rv4ylGdqiBbKXDLR7HuJO2jgB7Y 12w5R5XcOToTOoFMmQrPxI7mCOz3FoTcQ4R2K3MvzTPE/hMpp61liofor7DRi7bb2P5P CfCPijzdvDNPmDWqn85rewnUrGrABDT9xXBxEJHWJUvXfJ7JJftvx9GYfz3ulC4/qQ1i dmgW9Qumzq0DeqLl4QbFfRV8WDfTOgWpajU3hEgAUeaZzQe4zsp/2GN56ajucP4MxDhB HM0w== X-Gm-Message-State: AO0yUKVFY8xnwEQKYZ7j4BeihvC5/FsVrhCvXMuFTdBzAbjDeEB53cwn NLrmyfV5EHjFMS5cE+hx0wtD5g== X-Google-Smtp-Source: AK7set9+n/4emFTMm110a34dvRcSs53nGjqTBTMD9iP4DIYV9D0RnLLu8hdwlvwuU6Pqov9AhEl6ww== X-Received: by 2002:a05:6a20:1585:b0:c7:13bf:695e with SMTP id h5-20020a056a20158500b000c713bf695emr15791938pzj.18.1677198219228; Thu, 23 Feb 2023 16:23:39 -0800 (PST) Received: from [192.168.54.227] (rrcs-173-198-77-218.west.biz.rr.com. [173.198.77.218]) by smtp.gmail.com with ESMTPSA id r24-20020a62e418000000b00587fda4a260sm5538746pfh.9.2023.02.23.16.23.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Feb 2023 16:23:38 -0800 (PST) Message-ID: Date: Thu, 23 Feb 2023 14:23:35 -1000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v7 1/4] tcg: add 'size' param to probe_access_flags() Content-Language: en-US From: Richard Henderson To: Daniel Henrique Barboza , qemu-devel@nongnu.org Cc: qemu-riscv@nongnu.org, alistair.francis@wdc.com, bmeng@tinylab.org, liweiwei@iscas.ac.cn, zhiwei_liu@linux.alibaba.com References: <20230223234427.521114-1-dbarboza@ventanamicro.com> <20230223234427.521114-2-dbarboza@ventanamicro.com> <78a0f5a5-c2da-c016-1f15-981cf80bf676@linaro.org> In-Reply-To: <78a0f5a5-c2da-c016-1f15-981cf80bf676@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::1036; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1036.google.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.09, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 2/23/23 14:19, Richard Henderson wrote: > On 2/23/23 13:44, Daniel Henrique Barboza wrote: >> +    if (unlikely(flags & TLB_NOTDIRTY)) { >> +        notdirty_write(env_cpu(env), addr, 1, full, retaddr); > > That '1' should be 'size'.  Fixed locally. Hmph, well, that matches the interface, but it's only used to figure out how many pages to process, so any len that doesn't cross a page boundary (which we have checked) is equal bar the tracepoint. r~