From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49973C433DB for ; Wed, 17 Mar 2021 19:23:55 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 91E1764E74 for ; Wed, 17 Mar 2021 19:23:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 91E1764E74 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:43492 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMblp-00007S-I8 for qemu-devel@archiver.kernel.org; Wed, 17 Mar 2021 15:23:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49976) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMbee-0002TS-4G for qemu-devel@nongnu.org; Wed, 17 Mar 2021 15:16:28 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:23430) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lMbea-0001eN-DX for qemu-devel@nongnu.org; Wed, 17 Mar 2021 15:16:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616008583; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UQRYSp2L2DfGtOn232iC9yuuJmH4EI4XmCsl4N1uBew=; b=H+AXn6fmOncYIbEF2/ypeGT1hlKm9bXaL5aX91t+6ZLDRMSCpUuWUKkuGF15O5c/oQSr3C bNGr9vYfU9PEsRy5HlkrsmHlaVZokHngbFwI2oKo1lCBK7C1YV4sxegC9zKV6TZ2qWqdLc yEJlk+XAIVqbykDhghsmY/d0sfOHjoQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-347-VO2jYzPJPum4OA8UcbWMNA-1; Wed, 17 Mar 2021 15:16:21 -0400 X-MC-Unique: VO2jYzPJPum4OA8UcbWMNA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 17D2910866A0; Wed, 17 Mar 2021 19:16:20 +0000 (UTC) Received: from wainer-laptop.localdomain (ovpn-116-126.gru2.redhat.com [10.97.116.126]) by smtp.corp.redhat.com (Postfix) with ESMTP id 20DB45D9C0; Wed, 17 Mar 2021 19:16:09 +0000 (UTC) Subject: Re: [PATCH 0/3] tests/acceptance: Handle tests with "cpu" tag To: Cleber Rosa , John Snow , Eduardo Habkost References: <20210224212654.1146167-1-wainersm@redhat.com> <20210309185237.GB2155904@amachine.somewhere> From: Wainer dos Santos Moschetta Message-ID: Date: Wed, 17 Mar 2021 16:16:06 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210309185237.GB2155904@amachine.somewhere> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=wainersm@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Received-SPF: pass client-ip=216.205.24.124; envelope-from=wainersm@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.251, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: wrampazz@redhat.com, alex.bennee@linaro.org, qemu-devel@nongnu.org, pavel.dovgaluk@ispras.ru, pbonzini@redhat.com, philmd@redhat.com, aurelien@aurel32.net Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Added John and Eduardo, On 3/9/21 3:52 PM, Cleber Rosa wrote: > On Wed, Feb 24, 2021 at 06:26:51PM -0300, Wainer dos Santos Moschetta wrote: >> Currently the acceptance tests tagged with "machine" have the "-M TYPE" >> automatically added to the list of arguments of the QEMUMachine object. >> In other words, that option is passed to the launched QEMU. On this >> series it is implemented the same feature but instead for tests marked >> with "cpu". >> > Good! > >> There is a caveat, however, in case the test needs additional arguments to >> the CPU type they cannot be passed via tag, because the tags parser split >> values by comma. For example, in tests/acceptance/x86_cpu_model_versions.py, >> there are cases where: >> >> * -cpu is set to "Cascadelake-Server,x-force-features=on,check=off,enforce=off" >> * if it was tagged like "cpu:Cascadelake-Server,x-force-features=on,check=off,enforce=off" >> then the parser would break it into 4 tags ("cpu:Cascadelake-Server", >> "x-force-features=on", "check=off", "enforce=off") >> * resulting on "-cpu Cascadelake-Server" and the remaining arguments are ignored. >> >> For the example above, one should tag it (or not at all) as "cpu:Cascadelake-Server" >> AND self.vm.add_args('-cpu', "Cascadelake-Server,x-force-features=on,check=off,enforce=off"), >> and that results on something like: >> >> "qemu-system-x86_64 (...) -cpu Cascadelake-Server -cpu Cascadelake-Server,x-force-features=on,check=off,enforce=off". >> > There are clearly two problems here: > > 1) the tag is meant to be succinct, so that it can be used by users > selecting which tests to run. At the same time, it's a waste > to throw away the other information or keep it duplicate or > incosistent. > > 2) QEMUMachine doesn't keep track of command line arguments > (add_args() makes it pretty clear what's doing). But, on this type > of use case, a "set_args()" is desirable, in which case it would > overwrite the existing arguments for a given command line option. I like the idea of a "set_args()" to QEMUMachine as you describe above but it needs further discussion because I can see at least one corner case; for example, one can set the machine type as either -machine or -M, then what key it should be searched-and-replaced (if any) on the list of args? Unlike your suggestion, I thought on implement the method to deal with a single argument at time, as:     def set_arg(self, arg: Union[str, list], value: str) -> None:         """         Set the value of an argument from the list of extra arguments to be         given to the QEMU binary. If the argument does not exist then it is         added to the list.         If the ``arg`` parameter is a list then it will search and replace all         occurencies (if any). Otherwise a new argument is added and it is         used the first value of the ``arg`` list.         """         pass Does it sound good to you? Thanks! Wainer >> QEMU is going to ignore the first -cpu argument. See the patch 0003 for a reference. >> > But this would still be creating a QEMU command line with multiple > '-cpu' arguments, right? I understand this could be useful for > testing the behavior of the parameter parsing (if that's intended) but > it's bad practice to be generating incorrect command line in tests. > > Maybe just by tackling issue #2 this could be avoided. > > Cheers, > - Cleber.