From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>,
qemu-devel@nongnu.org
Cc: mst@redhat.com, marcel.apfelbaum@gmail.com
Subject: Re: [PATCH 2/4] pcie_regs: drop duplicated indicator value macros
Date: Sun, 5 Feb 2023 11:53:00 +0100 [thread overview]
Message-ID: <d2b469ca-bd6d-a1cc-1a5c-91e4beaa66bb@linaro.org> (raw)
In-Reply-To: <20230204174758.234951-3-vsementsov@yandex-team.ru>
On 4/2/23 18:47, Vladimir Sementsov-Ogievskiy wrote:
> We already have indicator values in
> include/standard-headers/linux/pci_regs.h , no reason to reinvent them
> in include/hw/pci/pcie_regs.h. (and we already have usage of
> PCI_EXP_SLTCTL_PWR_IND_BLINK and PCI_EXP_SLTCTL_PWR_IND_OFF in
> hw/pci/pcie.c, so let's be consistent)
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
> ---
> include/hw/pci/pcie_regs.h | 9 ---------
> hw/pci/pcie.c | 13 +++++++------
> 2 files changed, 7 insertions(+), 15 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2023-02-05 10:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-04 17:47 [PATCH 0/4] pcie: cleanup code and add trace point Vladimir Sementsov-Ogievskiy
2023-02-04 17:47 ` [PATCH 3/4] pcie: drop unused PCIExpressIndicator Vladimir Sementsov-Ogievskiy
2023-02-07 11:57 ` Philippe Mathieu-Daudé
2023-02-04 17:47 ` [PATCH 4/4] pcie: add trace-poing for power indicator transitions Vladimir Sementsov-Ogievskiy
[not found] ` <20230204174758.234951-3-vsementsov@yandex-team.ru>
2023-02-05 10:53 ` Philippe Mathieu-Daudé [this message]
[not found] ` <20230204174758.234951-2-vsementsov@yandex-team.ru>
2023-02-05 10:54 ` [PATCH 1/4] pcie: pcie_cap_slot_write_config(): use correct macro Philippe Mathieu-Daudé
[not found] ` <20230204174758.234951-6-vsementsov@yandex-team.ru>
2023-02-05 10:56 ` [PATCH 4/4] pcie: add trace-point for power indicator transitions Philippe Mathieu-Daudé
2023-02-07 10:39 ` Vladimir Sementsov-Ogievskiy
2023-03-01 20:53 ` Michael S. Tsirkin
-- strict thread matches above, loose matches on Subject: below --
2023-02-07 12:09 [PATCH 0/4] pcie: cleanup code and add trace point Vladimir Sementsov-Ogievskiy
2023-02-07 12:09 ` [PATCH 2/4] pcie_regs: drop duplicated indicator value macros Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2b469ca-bd6d-a1cc-1a5c-91e4beaa66bb@linaro.org \
--to=philmd@linaro.org \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).