From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5EB4CC433F5 for ; Fri, 1 Apr 2022 13:55:12 +0000 (UTC) Received: from localhost ([::1]:55480 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1naHk7-0002qw-D4 for qemu-devel@archiver.kernel.org; Fri, 01 Apr 2022 09:55:11 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53964) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1naHP0-0007Pa-P4 for qemu-devel@nongnu.org; Fri, 01 Apr 2022 09:33:23 -0400 Received: from [2607:f8b0:4864:20::22b] (port=34379 helo=mail-oi1-x22b.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1naHOy-00009R-VN for qemu-devel@nongnu.org; Fri, 01 Apr 2022 09:33:22 -0400 Received: by mail-oi1-x22b.google.com with SMTP id v75so2846723oie.1 for ; Fri, 01 Apr 2022 06:33:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=NVK/zeo+8149NhaV5iUMxzoJsaLWHaFF4vdGykbL+Yg=; b=OyZSfrohwY0j+RLrsuWMazQ24la3vxoiiAseTmB69DGqWcHUeczTN2/CvHMwApTvLh S/TzmJDyYcdBf+MlvYqOU9AKLsjhpFicnib2pdtY/qBdHcZ/moe0mz0hYsR0i/Jf5kn8 2nqiiVrxptN4HQvoHA8ClhYvcamwjQqpC2PY5+2URAS7Lxt6MKC5HbC7Z097afd9ytsS PJu3P7GsxTPEGp0WYW9Fc+58yLcLOrBlzXq5iW/IphpAC1LKJfHAYA2knXvEphqyb5lT dwRaKjK0Q7iqbakOQweI6cQMNeupSE1sIbAFpoZ8adaHJtAHeYpxYvGE/z2DsImrd5iN FeBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=NVK/zeo+8149NhaV5iUMxzoJsaLWHaFF4vdGykbL+Yg=; b=67VGoRIfy0C/LkdrTA5oRiqFouwmBjibbdlg0+yj4MyogkJcMTVMxs5a/Bp//vq8S9 MObEs0f/1ci8N2D+isoOfQ7u49pxymK5krrz+C6R8c0hivXMPe/cCG0Hlxm86xdPB1kj EwhvOU7rTFI21VD+HnSZBvSRNKW5BKL9HSnJhmQJtg9ivF4gDneIi8EH1EihIsvwul06 GKjMY+8o99tc4tv4fIXLqGAcW+alvGkkBO+m2QBXoCWbEuCCRCXIyxat6ZFnrH0GFIpY hjFtObdYku1N9KsW1Sb5hFh8szYLlOeb4sNne2jhRrJehYnGYresrFfcxymO2BhmySIQ JJJg== X-Gm-Message-State: AOAM530CVWkZsXo5x9uu66Csu88Z9A3Xl5lfgu+9itz9PbZIdmF0I4TS Nf2PLr6P9uSbcgHsTLrSctr/mA== X-Google-Smtp-Source: ABdhPJywTBsKhTfesEpdoGUJF2RQiYcppQ4gqrRq95mV5qvsGwirogOpfkiGonYE/8dtjktaUP4mDg== X-Received: by 2002:a05:6808:1413:b0:2ef:4a81:2ee8 with SMTP id w19-20020a056808141300b002ef4a812ee8mr4621682oiv.125.1648819999680; Fri, 01 Apr 2022 06:33:19 -0700 (PDT) Received: from [10.10.117.62] (fixed-187-188-190-73.totalplay.net. [187.188.190.73]) by smtp.gmail.com with ESMTPSA id d3-20020a9d2903000000b005cda765f578sm1119011otb.0.2022.04.01.06.33.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 01 Apr 2022 06:33:18 -0700 (PDT) Message-ID: Date: Fri, 1 Apr 2022 07:33:16 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PULL 06/29] softfloat: Move compare_floats to softfloat-parts.c.inc Content-Language: en-US To: Peter Maydell References: <20210603214131.629841-1-richard.henderson@linaro.org> <20210603214131.629841-7-richard.henderson@linaro.org> From: Richard Henderson In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::22b (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::22b; envelope-from=richard.henderson@linaro.org; helo=mail-oi1-x22b.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Alex_Benn=c3=a9e?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 3/31/22 12:06, Peter Maydell wrote: > PS: while you're there, there are also a bunch of new TCG related > issues where it alleges array indexes being out of bounds. I > suspect these are false positives, but it's probably faster > for you to analyse them. (I have a feeling Coverity can get > confused and claim an error because it's looking at an array > size it has cached from one target's NB_MMU_MODES value and > a code flow for a different target with a different NB_MMU_MODES.) Given the placement of one of the notes, 1760 static void *atomic_mmu_lookup(CPUArchState *env, target_ulong addr, 1761 MemOpIdx oi, int size, int prot, 1762 uintptr_t retaddr) 1763 { 1. assignment: Assigning: mmu_idx = get_mmuidx(oi). The value of mmu_idx may now be up to 15. 1764 size_t mmu_idx = get_mmuidx(oi); the range check in based only on the mask applied within get_mmuidx. I'll try adding an assert vs NB_MMU_MODES within that function. r~