qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Cornelia Huck <cohuck@redhat.com>, qemu-devel@nongnu.org
Cc: "Lukáš Doktor" <ldoktor@redhat.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	qemu-stable@nongnu.org
Subject: Re: [PATCH for-5.0] compat: disable edid on correct virtio-gpu device
Date: Wed, 18 Mar 2020 18:05:10 +0100	[thread overview]
Message-ID: <d2cf4311-5f67-db16-5719-03bf770889f1@redhat.com> (raw)
In-Reply-To: <20200318093919.24942-1-cohuck@redhat.com>

On 3/18/20 10:39 AM, Cornelia Huck wrote:
> Commit bb15791166c1 ("compat: disable edid on virtio-gpu base
> device") tried to disable 'edid' on the virtio-gpu base device.
> However, that device is not 'virtio-gpu', but 'virtio-gpu-device'.
> Fix it.
> 
> Fixes: bb15791166c1 ("compat: disable edid on virtio-gpu base device")
> Reported-by: Lukáš Doktor <ldoktor@redhat.com>
> Tested-by: Lukáš Doktor <ldoktor@redhat.com>
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Cornelia Huck <cohuck@redhat.com>

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> ---
> 
> Sorry about my testing failure on the original patch, and thanks
> to Lukáš for finding this.
> 
> ---
>   hw/core/machine.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/core/machine.c b/hw/core/machine.c
> index 9e8c06036faf..fa9f50db186e 100644
> --- a/hw/core/machine.c
> +++ b/hw/core/machine.c
> @@ -53,7 +53,7 @@ GlobalProperty hw_compat_4_0[] = {
>       { "secondary-vga",  "edid", "false" },
>       { "bochs-display",  "edid", "false" },
>       { "virtio-vga",     "edid", "false" },
> -    { "virtio-gpu",     "edid", "false" },
> +    { "virtio-gpu-device", "edid", "false" },
>       { "virtio-device", "use-started", "false" },
>       { "virtio-balloon-device", "qemu-4-0-config-size", "true" },
>       { "pl031", "migrate-tick-offset", "false" },
> 



      reply	other threads:[~2020-03-18 17:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-18  9:39 [PATCH for-5.0] compat: disable edid on correct virtio-gpu device Cornelia Huck
2020-03-18 17:05 ` Philippe Mathieu-Daudé [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d2cf4311-5f67-db16-5719-03bf770889f1@redhat.com \
    --to=philmd@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=ldoktor@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).