* [PATCH for-5.0] compat: disable edid on correct virtio-gpu device
@ 2020-03-18 9:39 Cornelia Huck
2020-03-18 17:05 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 2+ messages in thread
From: Cornelia Huck @ 2020-03-18 9:39 UTC (permalink / raw)
To: qemu-devel
Cc: Lukáš Doktor, Cornelia Huck, Gerd Hoffmann, qemu-stable
Commit bb15791166c1 ("compat: disable edid on virtio-gpu base
device") tried to disable 'edid' on the virtio-gpu base device.
However, that device is not 'virtio-gpu', but 'virtio-gpu-device'.
Fix it.
Fixes: bb15791166c1 ("compat: disable edid on virtio-gpu base device")
Reported-by: Lukáš Doktor <ldoktor@redhat.com>
Tested-by: Lukáš Doktor <ldoktor@redhat.com>
Cc: qemu-stable@nongnu.org
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
---
Sorry about my testing failure on the original patch, and thanks
to Lukáš for finding this.
---
hw/core/machine.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/core/machine.c b/hw/core/machine.c
index 9e8c06036faf..fa9f50db186e 100644
--- a/hw/core/machine.c
+++ b/hw/core/machine.c
@@ -53,7 +53,7 @@ GlobalProperty hw_compat_4_0[] = {
{ "secondary-vga", "edid", "false" },
{ "bochs-display", "edid", "false" },
{ "virtio-vga", "edid", "false" },
- { "virtio-gpu", "edid", "false" },
+ { "virtio-gpu-device", "edid", "false" },
{ "virtio-device", "use-started", "false" },
{ "virtio-balloon-device", "qemu-4-0-config-size", "true" },
{ "pl031", "migrate-tick-offset", "false" },
--
2.21.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH for-5.0] compat: disable edid on correct virtio-gpu device
2020-03-18 9:39 [PATCH for-5.0] compat: disable edid on correct virtio-gpu device Cornelia Huck
@ 2020-03-18 17:05 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-03-18 17:05 UTC (permalink / raw)
To: Cornelia Huck, qemu-devel
Cc: Lukáš Doktor, Gerd Hoffmann, qemu-stable
On 3/18/20 10:39 AM, Cornelia Huck wrote:
> Commit bb15791166c1 ("compat: disable edid on virtio-gpu base
> device") tried to disable 'edid' on the virtio-gpu base device.
> However, that device is not 'virtio-gpu', but 'virtio-gpu-device'.
> Fix it.
>
> Fixes: bb15791166c1 ("compat: disable edid on virtio-gpu base device")
> Reported-by: Lukáš Doktor <ldoktor@redhat.com>
> Tested-by: Lukáš Doktor <ldoktor@redhat.com>
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>
> Sorry about my testing failure on the original patch, and thanks
> to Lukáš for finding this.
>
> ---
> hw/core/machine.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/core/machine.c b/hw/core/machine.c
> index 9e8c06036faf..fa9f50db186e 100644
> --- a/hw/core/machine.c
> +++ b/hw/core/machine.c
> @@ -53,7 +53,7 @@ GlobalProperty hw_compat_4_0[] = {
> { "secondary-vga", "edid", "false" },
> { "bochs-display", "edid", "false" },
> { "virtio-vga", "edid", "false" },
> - { "virtio-gpu", "edid", "false" },
> + { "virtio-gpu-device", "edid", "false" },
> { "virtio-device", "use-started", "false" },
> { "virtio-balloon-device", "qemu-4-0-config-size", "true" },
> { "pl031", "migrate-tick-offset", "false" },
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-18 17:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-18 9:39 [PATCH for-5.0] compat: disable edid on correct virtio-gpu device Cornelia Huck
2020-03-18 17:05 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).