qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: Dominik Csapak <d.csapak@proxmox.com>, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, philmd@redhat.com, thuth@redhat.com, sw@weilnetz.de
Subject: Re: [Qemu-devel] [PATCH v2 0/3] add exit-script option to qemu
Date: Mon, 8 Oct 2018 11:28:31 +0800	[thread overview]
Message-ID: <d2ef3fb3-80ba-6edc-46fb-fa9d73542bc3@redhat.com> (raw)
In-Reply-To: <20181004114312.27346-1-d.csapak@proxmox.com>



On 2018年10月04日 19:43, Dominik Csapak wrote:
> this patch series aims to execute a script when qemu exits
> so that one can do cleanups when using --daemonize without
> having to use the qmp monitor

Hi:

Can you give a example of why it must be done through this way? It looks 
to me that we can do this by monitor the pid and behave accordingly 
through bash.

Thanks

>
> changes since v1:
>
> * refactored as qemu_launch_script, only for non-windows platforms
> * updated net/tap.c to use qemu_launch_script instead of launch_script
> * fixed a small error in the option description
>
> Dominik Csapak (3):
>    osdep: add qemu_launch_script for executing scripts
>    tap: use qemu_launch_script instead of launch_script
>    vl.c: call optional script when exiting
>
>   include/qemu/osdep.h | 12 +++++++++++
>   net/tap.c            | 56 ++++++++++------------------------------------------
>   qemu-options.hx      | 20 +++++++++++++++++++
>   util/oslib-posix.c   | 34 +++++++++++++++++++++++++++++++
>   util/oslib-win32.c   |  8 ++++++++
>   vl.c                 | 29 +++++++++++++++++++++++++++
>   6 files changed, 113 insertions(+), 46 deletions(-)
>

  parent reply	other threads:[~2018-10-08  3:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-04 11:43 [Qemu-devel] [PATCH v2 0/3] add exit-script option to qemu Dominik Csapak
2018-10-04 11:43 ` [Qemu-devel] [PATCH v2 1/3] osdep: add qemu_launch_script for executing scripts Dominik Csapak
2018-10-04 11:43 ` [Qemu-devel] [PATCH v2 2/3] tap: use qemu_launch_script instead of launch_script Dominik Csapak
2018-10-04 11:43 ` [Qemu-devel] [PATCH v2 3/3] vl.c: call optional script when exiting Dominik Csapak
2018-10-08  3:28 ` Jason Wang [this message]
2018-10-08  7:39   ` [Qemu-devel] [PATCH v2 0/3] add exit-script option to qemu Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d2ef3fb3-80ba-6edc-46fb-fa9d73542bc3@redhat.com \
    --to=jasowang@redhat.com \
    --cc=d.csapak@proxmox.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=sw@weilnetz.de \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).