From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: "Daniel P. Berrangé" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: Yanan Wang <wangyanan55@huawei.com>,
Eduardo Habkost <eduardo@habkost.net>,
Ani Sinha <anisinha@redhat.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Zhao Liu <zhao1.liu@intel.com>
Subject: Re: [PATCH] hw/core/machine: diagnose wrapping of maxmem
Date: Tue, 3 Dec 2024 16:39:41 +0100 [thread overview]
Message-ID: <d310853a-2d74-4fdc-bbbb-85d2a2c43fc4@linaro.org> (raw)
In-Reply-To: <20241127114057.255995-1-berrange@redhat.com>
On 27/11/24 12:40, Daniel P. Berrangé wrote:
> The 'maxmem' parameter parsed on the command line is held in uint64_t
> and then assigned to the MachineState field that is 'ram_addr_t'. This
> assignment will wrap on 32-bit hosts, silently changing the user's
> config request if it were over-sized.
>
> Improve the existing diagnositics for validating 'size', and add the
> same diagnostics for 'maxmem'
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> hw/core/machine.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
Patch queued, thanks.
prev parent reply other threads:[~2024-12-03 15:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-27 11:40 [PATCH] hw/core/machine: diagnose wrapping of maxmem Daniel P. Berrangé
2024-11-27 13:04 ` Ani Sinha
2024-12-03 15:39 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d310853a-2d74-4fdc-bbbb-85d2a2c43fc4@linaro.org \
--to=philmd@linaro.org \
--cc=anisinha@redhat.com \
--cc=berrange@redhat.com \
--cc=eduardo@habkost.net \
--cc=marcel.apfelbaum@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=wangyanan55@huawei.com \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).