From: Richard Henderson <richard.henderson@linaro.org>
To: Pavel Dovgalyuk <pavel.dovgalyuk@ispras.ru>, qemu-devel@nongnu.org
Cc: shorne@gmail.com, proljc@gmail.com
Subject: Re: [PATCH] target/openrisc: fix icount handling for timer instructions
Date: Thu, 5 Nov 2020 13:39:35 -0800 [thread overview]
Message-ID: <d3185b27-4df1-20b3-605f-cb82e158bb89@linaro.org> (raw)
In-Reply-To: <160457727672.17573.9713521384015502561.stgit@pasha-ThinkPad-X280>
On 11/5/20 3:54 AM, Pavel Dovgalyuk wrote:
> This patch adds icount handling to mfspr/mtspr instructions
> that may deal with hardware timers.
>
> Signed-off-by: Pavel Dovgalyuk <pavel.dovgalyuk@ispras.ru>
> ---
> target/openrisc/translate.c | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
Looks correct, but it would be better not to duplicate the code from
trans_l_mtspr, and use an is_jmp code (called DISAS_UPDATE_EXIT in some other
targets).
r~
next prev parent reply other threads:[~2020-11-05 21:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 11:54 [PATCH] target/openrisc: fix icount handling for timer instructions Pavel Dovgalyuk
2020-11-05 21:39 ` Richard Henderson [this message]
2020-11-06 6:36 ` Pavel Dovgalyuk
-- strict thread matches above, loose matches on Subject: below --
2021-03-29 7:42 Pavel Dovgalyuk
2021-03-30 22:05 ` Stafford Horne
2021-03-31 7:27 ` Pavel Dovgalyuk
2021-03-31 12:33 ` Stafford Horne
2021-03-31 12:48 ` Pavel Dovgalyuk
2021-03-31 14:30 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3185b27-4df1-20b3-605f-cb82e158bb89@linaro.org \
--to=richard.henderson@linaro.org \
--cc=pavel.dovgalyuk@ispras.ru \
--cc=proljc@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=shorne@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).