From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: ronyweng@synology.com, qemu-devel@nongnu.org, qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Chage disk serial length from 20 to 36
Date: Tue, 30 Aug 2016 17:35:14 +0200 [thread overview]
Message-ID: <d3303abd-af01-c6eb-439f-eeb1af81e673@redhat.com> (raw)
In-Reply-To: <87k2ey77fq.fsf@dusky.pond.sub.org>
On 30/08/2016 14:44, Markus Armbruster wrote:
>> > There is no limit in the SCSI spec. 20 was copy-pasted from virtio-blk
>> > which in turn was copy-pasted from ATA. So 36 is even more arbitrary,
>> > but bumping it up too much might cause issues (e.g. who knows there's no
>> > off-by-one somewhere if I make it 252, so that 256 is the maximum amount
>> > of returned data).
> This paragraph would make a nice addition to the commit message :)
Will do!
Paolo
prev parent reply other threads:[~2016-08-30 15:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-29 7:52 [Qemu-devel] [PATCH] Chage disk serial length from 20 to 36 ronyweng
2016-08-29 8:25 ` Paolo Bonzini
2016-08-30 12:08 ` Markus Armbruster
2016-08-30 12:19 ` Paolo Bonzini
2016-08-30 12:44 ` Markus Armbruster
2016-08-30 15:35 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3303abd-af01-c6eb-439f-eeb1af81e673@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=ronyweng@synology.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).