From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35755) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bel4O-00074b-NI for qemu-devel@nongnu.org; Tue, 30 Aug 2016 11:35:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bel4J-00081s-1V for qemu-devel@nongnu.org; Tue, 30 Aug 2016 11:35:23 -0400 References: <1472457138-23386-1-git-send-email-ronyweng@synology.com> <7e0e5c6b-dab7-7b87-2f4d-e07c3b64cef5@redhat.com> <8737lma27c.fsf@dusky.pond.sub.org> <96cebc60-089a-df39-583d-1b7f4c22bfa8@redhat.com> <87k2ey77fq.fsf@dusky.pond.sub.org> From: Paolo Bonzini Message-ID: Date: Tue, 30 Aug 2016 17:35:14 +0200 MIME-Version: 1.0 In-Reply-To: <87k2ey77fq.fsf@dusky.pond.sub.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Chage disk serial length from 20 to 36 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: ronyweng@synology.com, qemu-devel@nongnu.org, qemu-stable@nongnu.org On 30/08/2016 14:44, Markus Armbruster wrote: >> > There is no limit in the SCSI spec. 20 was copy-pasted from virtio-blk >> > which in turn was copy-pasted from ATA. So 36 is even more arbitrary, >> > but bumping it up too much might cause issues (e.g. who knows there's no >> > off-by-one somewhere if I make it 252, so that 256 is the maximum amount >> > of returned data). > This paragraph would make a nice addition to the commit message :) Will do! Paolo