From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48480) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bS4CH-0000a2-Rg for qemu-devel@nongnu.org; Tue, 26 Jul 2016 11:23:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bS4CD-0003f8-2D for qemu-devel@nongnu.org; Tue, 26 Jul 2016 11:23:05 -0400 References: <1469538827-8219-1-git-send-email-berrange@redhat.com> From: Max Reitz Message-ID: Date: Tue, 26 Jul 2016 17:22:48 +0200 MIME-Version: 1.0 In-Reply-To: <1469538827-8219-1-git-send-email-berrange@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="NvC8CunoILrDOUS3h9wMqAiiidHwg5cnf" Subject: Re: [Qemu-devel] [PATCH] iotest: fix python based IO tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --NvC8CunoILrDOUS3h9wMqAiiidHwg5cnf From: Max Reitz To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: qemu-block@nongnu.org Message-ID: Subject: Re: [PATCH] iotest: fix python based IO tests References: <1469538827-8219-1-git-send-email-berrange@redhat.com> In-Reply-To: <1469538827-8219-1-git-send-email-berrange@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 26.07.2016 15:13, Daniel P. Berrange wrote: > The previous commit refactoring iotests.py: >=20 > commit 66613974468fb6e1609fb3eabf55981b1ee436cf > Author: Daniel P. Berrange > Date: Wed Jul 20 14:23:10 2016 +0100 >=20 > scripts: refactor the VM class in iotests for reuse >=20 > was not properly tested and included a number of broken > bits. >=20 > - The 'event_match' method was not moved into qemu.py > - The 'self._args' list parameter in QEMUMachine needs > to be copied otherwise modifications will affect the > global 'qemu_opts' variable in iotests.py > - The QEMUQtestMachine class methods had inverted > parameter order for the super() calls > - The QEMUQtestMachine class forgot to add > '-machine accel=3Dqtest' > - The QEMUQtestMachine class constructor needs to set > a default 'name' value before using it as it may > be None > - The QEMUQtestMachine class constructor needs to use > named parameters when calling the super constructor > as it is leaving out some positional parameters. > - The 'qemu_prog' variable should be a string not a > list in iotests.py > - The VM classs constructor needs to use named > parameters when calling the super constructor > as it is leaving out some positional parameters. >=20 > Signed-off-by: Daniel P. Berrange > --- > scripts/qemu.py | 19 ++++++++++++++++++- > scripts/qtest.py | 15 +++++++++------ > tests/qemu-iotests/iotests.py | 23 +++-------------------- > 3 files changed, 30 insertions(+), 27 deletions(-) Thanks! :-) Applied to my block tree: https://github.com/XanClic/qemu/commits/block Max --NvC8CunoILrDOUS3h9wMqAiiidHwg5cnf Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEvBAEBCAAZBQJXl4BIEhxtcmVpdHpAcmVkaGF0LmNvbQAKCRA7sUIC6DisrfhW B/0V2ZTEK4/1kKtR25/gDOSCjFXU52RiHnPZwbpkJr8DvYad9PbDrDGEb4jmgjGb 2ZC9+Jz5PrqxMLXf0vtX4tTM0toW7Yu2QrkWb1gm9gWw6Of8CeOUAoC93usqYooW RHBvNxP78a7MEft1WnMqULJ67QJi89hxxJME+x3+GOsD/I0hjYtQP+VHLveEsG+Q P/CJ2jgdgInxm5FhPbmPP8o4R08tMiY63h2i2aVIj1eq3Z1NHnp7XuLJruYmC0aw UEdBU+MA990npb4uKqRnFnkOHeC7xCnud5jKYXgbUx1iekQ0NE3UgDChE8FX5sf8 nK1saXTPTtqV/enD7UEFYXyM =WIZ/ -----END PGP SIGNATURE----- --NvC8CunoILrDOUS3h9wMqAiiidHwg5cnf--