iPXE: update submodule

iPXE: update submodule

[Philippe Mathieu-Daudé]

Hi Gerd,

'make -C roms efirom' is failing on Fedora 30.

Can you update the iPXE submodule so we get these buildsys commits:

c742c576 [build] Move predefined all-drivers build shortcut to Makefile
a4f8c6e3 [build] Do not apply WORKAROUND_CFLAGS for host compiler
1dd56dbd [build] Workaround compilation error with gcc 9.1
412acd78 [build] Fix "'%s' directive argument is null" error

Thanks,

Phil.

Re: iPXE: update submodule

[Gerd Hoffmann]

On Mon, Dec 02, 2019 at 12:19:50PM +0100, Philippe Mathieu-Daudé wrote:
> Hi Gerd,
> 
> 'make -C roms efirom' is failing on Fedora 30.
> 
> Can you update the iPXE submodule so we get these buildsys commits:
> 
> c742c576 [build] Move predefined all-drivers build shortcut to Makefile
> a4f8c6e3 [build] Do not apply WORKAROUND_CFLAGS for host compiler
> 1dd56dbd [build] Workaround compilation error with gcc 9.1
> 412acd78 [build] Fix "'%s' directive argument is null" error

Hmm.  Sure, can do that, but the question is for 4.2 or 5.0.  Updating
ipxe that close to the release makes me nervous, but shipping a ipxe
version which doesn't build with recent compilers in the release tarball
isn't great either.

I'd tend to go the 5.0 route.
Comments?
Suggestions?

cheers,
  Gerd

Re: iPXE: update submodule

[Thomas Huth]

On 02/12/2019 13.18, Gerd Hoffmann wrote:
> On Mon, Dec 02, 2019 at 12:19:50PM +0100, Philippe Mathieu-Daudé wrote:
>> Hi Gerd,
>>
>> 'make -C roms efirom' is failing on Fedora 30.
>>
>> Can you update the iPXE submodule so we get these buildsys commits:
>>
>> c742c576 [build] Move predefined all-drivers build shortcut to Makefile
>> a4f8c6e3 [build] Do not apply WORKAROUND_CFLAGS for host compiler
>> 1dd56dbd [build] Workaround compilation error with gcc 9.1
>> 412acd78 [build] Fix "'%s' directive argument is null" error
> 
> Hmm.  Sure, can do that, but the question is for 4.2 or 5.0.  Updating
> ipxe that close to the release makes me nervous, but shipping a ipxe
> version which doesn't build with recent compilers in the release tarball
> isn't great either.
> 
> I'd tend to go the 5.0 route.
> Comments?
> Suggestions?

I think the average users don't rebuild the rom binaries on their own
from the release tarballs ... so IMHO this should rather go into 5.0.
Just my 0.02 € of course.

 Thomas

Re: iPXE: update submodule

[Philippe Mathieu-Daudé]

On 12/2/19 1:18 PM, Gerd Hoffmann wrote:
> On Mon, Dec 02, 2019 at 12:19:50PM +0100, Philippe Mathieu-Daudé wrote:
>> Hi Gerd,
>>
>> 'make -C roms efirom' is failing on Fedora 30.
>>
>> Can you update the iPXE submodule so we get these buildsys commits:
>>
>> c742c576 [build] Move predefined all-drivers build shortcut to Makefile
>> a4f8c6e3 [build] Do not apply WORKAROUND_CFLAGS for host compiler
>> 1dd56dbd [build] Workaround compilation error with gcc 9.1
>> 412acd78 [build] Fix "'%s' directive argument is null" error
> 
> Hmm.  Sure, can do that, but the question is for 4.2 or 5.0.  Updating
> ipxe that close to the release makes me nervous, but shipping a ipxe
> version which doesn't build with recent compilers in the release tarball
> isn't great either.
> 
> I'd tend to go the 5.0 route.

I think 5.0 is OK, because if distributions build it, the are probably 
already backporting these patches, so they can backport the QEMU patch 
instead.