From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EFEAC433E2 for ; Mon, 14 Sep 2020 01:46:42 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 83660208C7 for ; Mon, 14 Sep 2020 01:46:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="FBiP++UZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 83660208C7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53302 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHdZo-0007Ai-EX for qemu-devel@archiver.kernel.org; Sun, 13 Sep 2020 21:46:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57690) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHdZ7-0006cv-ND for qemu-devel@nongnu.org; Sun, 13 Sep 2020 21:45:57 -0400 Received: from mail-pf1-x442.google.com ([2607:f8b0:4864:20::442]:44992) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kHdZ5-00074O-3N for qemu-devel@nongnu.org; Sun, 13 Sep 2020 21:45:57 -0400 Received: by mail-pf1-x442.google.com with SMTP id o20so11195811pfp.11 for ; Sun, 13 Sep 2020 18:45:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=3LihhM1ePbr3F1AZDzpEqifVn3GiR/199hCi1SIAod4=; b=FBiP++UZ/My1B9muJqSXiYqcloB6NFqrowYZwv+GClONf/vSby0HNyvBd2tVb/D8Gz auTp74kZdr7QT5VM7xvJSw6lKO2sj+WGuvmo/HjX954DCUDo+Vl4hiCBiXqpH7Qm7/YB xPW2BWfcJYrHxHQ/W2iccUSiagGRRSFsxOhcuYawoZgprmeGiSwfPtWSxSc4ZBvlaUAL ig34pkwfwPPO8ZX+7wSxYg9NbdPju1xeiNwdOOz5yUXwXoYoAsBvHRD/hszVzSu8ayHf Oumyu3LyIKcO1uOyWKZDTIlABY/0P5w5bFmwARXLWFIoORCIvvajSaSDJ7K7OMr+27MP Fx8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3LihhM1ePbr3F1AZDzpEqifVn3GiR/199hCi1SIAod4=; b=RMYgai5ZTAbs0i9MBF1s9L1IZQmifKs21ELFHdnNTwo+J5V6bZ6J/yi3UmLqj2c+ez hqJj1n80NqAobFK7HcRzCwupdPPvmC9drfadv2nG0NiIi6g6vpHZhQdsWlOtUfD5U02d iOUqShogpRO8kVv3GdNi7UihZ0NbNuWYh332xuI2v3SD627tUA62DaOALTKXRXVq73q5 N5LCdvM7ljKCq+GQx/QMgRzw3DkYULL4QoOe/ziQeJJf/tjeZXEWIOOPKbK1XRkOuvHy kM3LV8900Srjqwy/MesOa4e8ZEn17NW3f33woev7jlFdqBl/g1W0TmrNNbG3SaBITgXs kt8g== X-Gm-Message-State: AOAM532K10FFiUt2U0ZzUczfAhwAWZgf10GG4YTmLsqhEqjDPgxc9+E3 5hmTk2UD7A3MmU/YA1Cp16cPDA== X-Google-Smtp-Source: ABdhPJyMLtXnhkhcLCF2XyBa6FESLqH+6TEaf+AiUh/iBX7PWZUMCmiaFCGc5fQcvbK1fDEj3RaD2A== X-Received: by 2002:a17:902:b583:b029:d1:c807:da44 with SMTP id a3-20020a170902b583b02900d1c807da44mr2673096pls.15.1600047953482; Sun, 13 Sep 2020 18:45:53 -0700 (PDT) Received: from [192.168.1.11] ([71.212.141.89]) by smtp.gmail.com with ESMTPSA id u10sm8411250pfn.122.2020.09.13.18.45.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 13 Sep 2020 18:45:52 -0700 (PDT) Subject: Re: [PATCH v6 2/7] hw/misc/led: Allow connecting from GPIO output To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20200912134041.946260-1-f4bug@amsat.org> <20200912134041.946260-3-f4bug@amsat.org> From: Richard Henderson Message-ID: Date: Sun, 13 Sep 2020 18:45:50 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200912134041.946260-3-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::442; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x442.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , Eduardo Habkost , Andrew Jeffery , qemu-arm@nongnu.org, =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , Paolo Bonzini , Luc Michel , Joel Stanley Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 9/12/20 6:40 AM, Philippe Mathieu-Daudé wrote: > Some devices expose GPIO lines. > > Add a GPIO qdev input to our LED device, so we can > connect a GPIO output using qdev_connect_gpio_out(). > > When used with GPIOs, the intensity can only be either > minium or maximum. This depends of the polarity of the > GPIO (which can be inverted). > Declare the GpioPolarity type to model the polarity. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/misc/led.h | 10 ++++++++++ > include/hw/qdev-core.h | 16 ++++++++++++++++ > hw/misc/led.c | 17 ++++++++++++++++- > 3 files changed, 42 insertions(+), 1 deletion(-) git-submodule-update