From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Zenghui Yu <zenghui.yu@linux.dev>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: agraf@csgraf.de, mads@ynddal.dk, peter.maydell@linaro.org
Subject: Re: [PATCH] hvf: arm: Remove $pc from trace_hvf_data_abort()
Date: Mon, 14 Jul 2025 14:10:16 +0200 [thread overview]
Message-ID: <d338428e-ae84-47f4-8f60-b72b3cbe8dcd@linaro.org> (raw)
In-Reply-To: <20250713154719.4248-1-zenghui.yu@linux.dev>
On 13/7/25 17:47, Zenghui Yu wrote:
> We don't synchronize vcpu registers from the hardware accelerator (e.g., by
> cpu_synchronize_state()) in the Dabort handler, so env->pc points to the
> instruction which has nothing to do with the Dabort at all.
>
> And it doesn't seem to make much sense to log PC in every Dabort handler,
> let's just remove it from this trace event.
>
> Signed-off-by: Zenghui Yu <zenghui.yu@linux.dev>
> ---
> target/arm/hvf/hvf.c | 2 +-
> target/arm/hvf/trace-events | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
prev parent reply other threads:[~2025-07-14 13:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-13 15:47 [PATCH] hvf: arm: Remove $pc from trace_hvf_data_abort() Zenghui Yu
2025-07-14 8:24 ` Mads Ynddal
2025-07-14 10:19 ` Peter Maydell
2025-07-14 12:10 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d338428e-ae84-47f4-8f60-b72b3cbe8dcd@linaro.org \
--to=philmd@linaro.org \
--cc=agraf@csgraf.de \
--cc=mads@ynddal.dk \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=zenghui.yu@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).