Re: [SPAM] [PATCH v1 12/13] hw/arm/aspeed: Split Supermicro X11SPI machine into a separate file for maintainability

["Cédric Le Goater" <clg@kaod.org>]

On 10/23/25 12:01, Jamin Lin wrote:
> This commit moves the Supermicro X11SPI BMC machine definition from
> aspeed.c into a new standalone file aspeed_ast2500_supermicro-x11spi.c,
> and adds a dedicated I²C initialization function for the platform.
> 
> The refactor continues the effort to modularize Aspeed platform support,
> ensuring each machine model is defined in its own source file. This improves
> code organization, readability, and simplifies maintenance when adding or
> modifying platform-specific behavior.
> 
> Previously, the Supermicro X11SPI machine reused
> palmetto_bmc_i2c_init() for its I²C setup. To make the machine
> definition fully self-contained, the function was copied and renamed
> to supermicro_x11spi_bmc_i2c_init(). This ensures that the machine
> can evolve independently without depending on Palmetto’s board logi
> 
> Key updates include:
> - Moved SUPERMICRO_X11SPI_BMC_HW_STRAP1 macro and machine class init
> (aspeed_machine_supermicro_x11spi_bmc_class_init) into a new file.
> - Added new function supermicro_x11spi_bmc_i2c_init() copied from
> palmetto_bmc_i2c_init() for independent control.
> - Updated the machine definition to use the new I²C init function.
> - Registered the new source file in meson.build.
> - Removed all Supermicro X11SPI-related definitions from aspeed.c.
> 
> No functional changes.
> 
> Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
> ---
>   hw/arm/aspeed.c                           | 32 ----------
>   hw/arm/aspeed_ast2500_supermicro-x11spi.c | 76 +++++++++++++++++++++++
>   hw/arm/meson.build                        |  1 +
>   3 files changed, 77 insertions(+), 32 deletions(-)
>   create mode 100644 hw/arm/aspeed_ast2500_supermicro-x11spi.c
> 


Reviewed-by: Cédric Le Goater <clg@redhat.com>

Thanks,

C.