Re: [PATCH] hw/ufs: Modify lu.c to share codes with SCSI subsystem

[Jeuk Kim <jeuk20.kim@gmail.com>]

On 10/30/2023 1:11 PM, Philippe Mathieu-Daudé wrote:
> Hi Jeuk,
>
> On 20/10/23 03:51, Jeuk Kim wrote:
>> This patch removes the code that ufs-lu was duplicating from
>> scsi-hd and allows them to share code.
>>
>> It makes ufs-lu have a virtual scsi-bus and scsi-hd internally.
>> This allows scsi related commands to be passed thorugh to the scsi-hd.
>> The query request and nop command work the same as the existing logic.
>>
>> Well-known lus do not have a virtual scsi-bus and scsi-hd, and
>> handle the necessary scsi commands by emulating them directly.
>>
>> Signed-off-by: Jeuk Kim <jeuk20.kim@samsung.com>
>> ---
>>   hw/ufs/lu.c            | 1473 +++++++---------------------------------
>
> I liked this patch intent, but almost 1500 lines changed in a single
> patch make it impossible to review. Ideally each patch shouldn't modify
> more than 100 lines, otherwise reviewers are either exhausted or can't
> be careful enough and miss possible bugs or design issues.
>
> Regards,
>
> Phil.
>
Hi Phil,

Thanks for the comment.
I thought that since most of the code fixes were code removals and
were functionally bundled together, it was right to submit them as a 
single patch.

However, I agree that it was inconsiderate of the reviewers, and I 
apologize for that.

Next time, I'll size the patch appropriately as you suggest.

Thanks,
Jeuk