From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 204B9EB64D8 for ; Wed, 14 Jun 2023 06:04:10 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q9JbX-0004bv-B6; Wed, 14 Jun 2023 02:03:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q9JbO-0004bI-Ag for qemu-devel@nongnu.org; Wed, 14 Jun 2023 02:03:30 -0400 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q9JbM-0004O6-85 for qemu-devel@nongnu.org; Wed, 14 Jun 2023 02:03:29 -0400 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-3f8cdb12719so1763555e9.1 for ; Tue, 13 Jun 2023 23:03:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686722606; x=1689314606; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Z1mflwoxiIcBk9lnaXGGSMIDSBExg6+3pv6d7Z4z+S8=; b=BVkHKrOCZ9Q7rGH/9e+IsUckdyK7TVTeOZT506pfXHrQ+2KZf58fORbc5qHZZchg9o M2lHyQGceuQMKUBhwtPoqmGjS4kcwMCp3RjwSYBfqH6/zuqzpnIPN/bKYmw0/anPX0iQ Xqnb0sIo+xG0ppGsGlJ0PQKanvTH8QwvJB9riTZooBngQeOaQ0am10vnLByRAVuRV6Xb y1i1pP/wFSS87SH1AJ9sGGisF0B1fYcJ4ESkEh4sTFVzYud4dFI5LL/O1ehi+wmShYtK hF95aWmMkO6l4lmhG06+JyxZEpeRQCn6knLwQpVDiMxVzzvej5yBQeaWe7i2TQezpxcd Xwqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686722606; x=1689314606; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Z1mflwoxiIcBk9lnaXGGSMIDSBExg6+3pv6d7Z4z+S8=; b=EZu2NQdawvFiR7A1VmQK3gsLqO7w2Vb7maDz25givw8SB+HSc0+N0MUC7K/6lWq6dG 0JeVx1+yyhPfNbapJICzWVqpOtDiB0Mm1GQd7+bdkm8lYCBrS0f52vdWirj2+vOwRozL Lo8Q9hrO/4ZN/dc80iCD+Qet4pypyZasCq1dDyJP8IHNZIWHZDUDuRQm2p1b3eiDljXe 1x9O2Z59G6R2v3K4ZUEljb+ZoA05L9zFjZ10dg84OMeYD9gC6yFKxnnOdGuR+fkbEdkQ Ww71fp3QETitr3iM5qE7QIcE6XyqTR8saL/YUFRUrYE+GalANmR5Suyq37DLGqNmgW6a UwIg== X-Gm-Message-State: AC+VfDzN3iGgd9hdsDxZS3F4xj5d5ToUih0iK7cw1LYiyuLbzypVa5U1 0HdGzXj8QzT0DGeI/wIyuWkUPA== X-Google-Smtp-Source: ACHHUZ4Oy0q0ObfSzblcLeHe8n7VAQtlX3ACcxY8s+TdjCsHeqYR9HQCZovA2Ij8zyNT0zXI8ZolXQ== X-Received: by 2002:a7b:c40b:0:b0:3f4:27ff:7d48 with SMTP id k11-20020a7bc40b000000b003f427ff7d48mr9406197wmi.19.1686722606261; Tue, 13 Jun 2023 23:03:26 -0700 (PDT) Received: from [192.168.4.112] (90-182-62-66.rcp.o2.cz. [90.182.62.66]) by smtp.gmail.com with ESMTPSA id m21-20020a7bce15000000b003f8cd4892b3sm3581895wmc.3.2023.06.13.23.03.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Jun 2023 23:03:25 -0700 (PDT) Message-ID: Date: Wed, 14 Jun 2023 08:03:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v3 2/4] hw/misc/bcm2835_property: Use 'raspberrypi-fw-defs.h' definitions Content-Language: en-US To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: Sergey Kambalin , qemu-arm@nongnu.org, Peter Maydell References: <20230612223456.33824-1-philmd@linaro.org> <20230612223456.33824-3-philmd@linaro.org> From: Richard Henderson In-Reply-To: <20230612223456.33824-3-philmd@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=richard.henderson@linaro.org; helo=mail-wm1-x335.google.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.098, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 6/13/23 00:34, Philippe Mathieu-Daudé wrote: > From: Sergey Kambalin > > Replace magic property values by a proper definition, > removing redundant comments. > > Signed-off-by: Sergey Kambalin > Message-Id:<20230531155258.8361-1-sergey.kambalin@auriga.com> > [PMD: Split from bigger patch: 2/4] > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/misc/bcm2835_property.c | 101 +++++++++++++++++++------------------ > 1 file changed, 51 insertions(+), 50 deletions(-) Reviewed-by: Richard Henderson r~