From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: "Kamil Szczęk" <kamil@szczek.dev>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: "qemu-trivial@nongnu.org" <qemu-trivial@nongnu.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Bernhard Beschow <shentey@gmail.com>,
Joelle van Dyne <j@getutm.app>
Subject: Re: [PATCH-for-9.1 v3 1/2] hw/i386/pc: Unify vmport=auto handling
Date: Mon, 19 Aug 2024 11:45:01 +0200 [thread overview]
Message-ID: <d34e9015-432c-4663-a891-107c039ab4c4@linaro.org> (raw)
In-Reply-To: <v8pz1uwgIYWkidgZK-o8H-qJvnSyl0641XVmNO43Qls307AA3QRPuad_py6xGe0JAxB6yDEe76oZ8tau_n-2Y6sJBCKzCujNbEUUFhd-ahI=@szczek.dev>
On 17/8/24 17:25, Kamil Szczęk wrote:
> The code which translates vmport=auto to on/off is currently separate
> for each PC machine variant, while being functionally equivalent.
> This moves the translation into a shared initialization function, while
> also tightening the enum assertion.
>
> Signed-off-by: Kamil Szczęk <kamil@szczek.dev>
> ---
> hw/i386/pc.c | 5 +++++
> hw/i386/pc_piix.c | 5 -----
> hw/i386/pc_q35.c | 5 -----
> 3 files changed, 5 insertions(+), 10 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2024-08-19 9:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-17 15:24 [PATCH-for-9.1 v3 0/2] hw/i386/pc: Fix vmport option handling Kamil Szczęk
2024-08-17 15:25 ` [PATCH-for-9.1 v3 1/2] hw/i386/pc: Unify vmport=auto handling Kamil Szczęk
2024-08-19 9:45 ` Philippe Mathieu-Daudé [this message]
2024-08-17 15:26 ` [PATCH-for-9.1 v3 2/2] hw/i386/pc: Ensure vmport prerequisites are fulfilled Kamil Szczęk
2024-08-19 8:22 ` [PATCH-for-9.1 v3 0/2] hw/i386/pc: Fix vmport option handling Bernhard Beschow
2024-08-20 10:39 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d34e9015-432c-4663-a891-107c039ab4c4@linaro.org \
--to=philmd@linaro.org \
--cc=j@getutm.app \
--cc=kamil@szczek.dev \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=shentey@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).