From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DC17BC5320E for ; Mon, 19 Aug 2024 09:45:55 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sfyx7-00086e-GS; Mon, 19 Aug 2024 05:45:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sfywp-00081A-5M for qemu-devel@nongnu.org; Mon, 19 Aug 2024 05:45:11 -0400 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sfywn-0007sO-17 for qemu-devel@nongnu.org; Mon, 19 Aug 2024 05:45:10 -0400 Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-42803bbf842so45117525e9.1 for ; Mon, 19 Aug 2024 02:45:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1724060706; x=1724665506; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=GSVvw+LToAhIkv7UFomu6iKZWhqsx6SkthRz7pgB8HA=; b=uUZFTLWrf/PyuaHFADOER3hu9VQl+m+csM5GN+81LGbDrBvYxyOAAGEYUAYTQMCdtd LqeqxvEEYFz88xtC9N70HqpLdklQk/wedR4fKGgC+jMnyGsPBFBkqVK6fxFKgAUZvEYO Zem2cC49vjh1EBd5V30jCzYGO/w6D77s5by3l05pnxFwnSXmmaq8NefG4XjGsuI4Oibv nWUJvsSs/19HsiKPhXqvl+gJBt3Hk43XjhsbEvflNHFvHEBZtuEO5VFSLo5Jrd3thNv7 DtrSdb45V5WBccadXRjJBvxweSVumAF/0YcwRW0D9ZggjudzjKMx/zjWv40kSmj4MqCY /rIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724060706; x=1724665506; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GSVvw+LToAhIkv7UFomu6iKZWhqsx6SkthRz7pgB8HA=; b=eK0kyUyaeonyAI0zfyvmVxBRtjIk4ksr0w+KROsUhEznH1pc01bPJSriiynF2EYXTd olr/id/vbvZ6hkcKHbmmu7a8nrPnKc3YzMxgU+rNGHCNQ/FmhCoTpX7Wxg/d+MHicY9I VmUDsF6XyjxLZq95pzzsybQo6pIBZ/SLSqjlCVLKuarIQiSdFBSkZinjphGcZxlH+eou 47ziSKeKof6/JWP2HuNgdRA1DS+ucs//AFCf6KAJrxPLRhwWVlHLvXv0Dkzj2m5Kx1jA JYqVo/cMRUPymnd/ZLr58w7ykBs365SkCT2quhBM9ARx6bqTvOWzHIH5jjGvarLEpXr0 kYXA== X-Forwarded-Encrypted: i=1; AJvYcCVUnGgv08putC2nftwOrexLDFZ2/XJ/Dt6U2AiaxL80V8mVJKwlSuTrFCVXtXDPzSlagI/aVgQtgScG7QNYDC6uOCTujso= X-Gm-Message-State: AOJu0Yw4fgfH9qyOSzDdXxXm/SRTmHbmt3eNdGQrb2KxoTEwvHKRzp/m ylp8TOdZU5Kc5DmL247D8s54qxal+nv0nGDFaxVX9dgh/CwRzm2ScNfuPNUwERM= X-Google-Smtp-Source: AGHT+IHlwZUSKVxYP6mL0kkYd6WY+av7xVhkS+4m0Ot/PugLk7rkLVtPYOG0GSBZFR0OE/76a6W6Ag== X-Received: by 2002:a05:600c:3d98:b0:425:81bd:e5ee with SMTP id 5b1f17b1804b1-429ed79b89cmr78775295e9.16.1724060706282; Mon, 19 Aug 2024 02:45:06 -0700 (PDT) Received: from [192.168.166.175] (83.red-95-127-94.dynamicip.rima-tde.net. [95.127.94.83]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-429ded2931asm155090975e9.17.2024.08.19.02.45.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Aug 2024 02:45:05 -0700 (PDT) Message-ID: Date: Mon, 19 Aug 2024 11:45:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH-for-9.1 v3 1/2] hw/i386/pc: Unify vmport=auto handling To: =?UTF-8?Q?Kamil_Szcz=C4=99k?= , "qemu-devel@nongnu.org" Cc: "qemu-trivial@nongnu.org" , "Michael S. Tsirkin" , Paolo Bonzini , Bernhard Beschow , Joelle van Dyne References: Content-Language: en-US From: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=philmd@linaro.org; helo=mail-wm1-x334.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 17/8/24 17:25, Kamil Szczęk wrote: > The code which translates vmport=auto to on/off is currently separate > for each PC machine variant, while being functionally equivalent. > This moves the translation into a shared initialization function, while > also tightening the enum assertion. > > Signed-off-by: Kamil Szczęk > --- > hw/i386/pc.c | 5 +++++ > hw/i386/pc_piix.c | 5 ----- > hw/i386/pc_q35.c | 5 ----- > 3 files changed, 5 insertions(+), 10 deletions(-) Reviewed-by: Philippe Mathieu-Daudé