From: Jan Kiszka <jan.kiszka@web.de>
To: Avi Kivity <avi@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
Glauber Costa <glommer@redhat.com>,
qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: [Qemu-devel] [PATCH v2 14/17] kvm: x86: Introduce kvmclock device to save/restore its state
Date: Mon, 3 Jan 2011 09:33:04 +0100 [thread overview]
Message-ID: <d35c17614fa7646ff48ef57f7922aec01e1044a6.1294043582.git.jan.kiszka@web.de> (raw)
In-Reply-To: <cover.1294043582.git.jan.kiszka@web.de>
In-Reply-To: <cover.1294043582.git.jan.kiszka@web.de>
From: Jan Kiszka <jan.kiszka@siemens.com>
If kvmclock is used, which implies the kernel supports it, register a
kvmclock device with the sysbus. Its main purpose is to save and restore
the kernel state on migration, but this will also allow to visualize it
one day.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
CC: Glauber Costa <glommer@redhat.com>
---
target-i386/kvm.c | 71 ++++++++++++++++++++++++++++++++++++++++++++++++++++-
1 files changed, 70 insertions(+), 1 deletions(-)
diff --git a/target-i386/kvm.c b/target-i386/kvm.c
index 26f459c..c4b6813 100644
--- a/target-i386/kvm.c
+++ b/target-i386/kvm.c
@@ -29,6 +29,7 @@
#include "hw/apic.h"
#include "ioport.h"
#include "kvm_x86.h"
+#include "hw/sysbus.h"
#ifdef CONFIG_KVM_PARA
#include <linux/kvm_para.h>
@@ -309,6 +310,64 @@ void kvm_inject_x86_mce(CPUState *cenv, int bank, uint64_t status,
#endif
}
+#ifdef KVM_CAP_ADJUST_CLOCK
+typedef struct KVMClockState {
+ SysBusDevice busdev;
+ uint64_t clock;
+ struct kvm_clock_data data;
+} KVMClockState;
+
+static void kvmclock_pre_save(void *opaque)
+{
+ KVMClockState *s = opaque;
+ struct kvm_clock_data data;
+ int ret;
+
+ ret = kvm_vm_ioctl(KVM_GET_CLOCK, &data);
+ if (ret < 0) {
+ fprintf(stderr, "KVM_GET_CLOCK failed: %s\n", strerror(ret));
+ data.clock = 0;
+ }
+ s->clock = data.clock;
+}
+
+static int kvmclock_post_load(void *opaque, int version_id)
+{
+ KVMClockState *s = opaque;
+ struct kvm_clock_data data;
+
+ data.clock = s->clock;
+ data.flags = 0;
+ return kvm_vm_ioctl(KVM_SET_CLOCK, &data);
+}
+
+static int kvmclock_init(SysBusDevice *dev)
+{
+ return 0;
+}
+
+static const VMStateDescription kvmclock_vmsd= {
+ .name = "kvmclock",
+ .version_id = 1,
+ .minimum_version_id = 1,
+ .minimum_version_id_old = 1,
+ .pre_save = kvmclock_pre_save,
+ .post_load = kvmclock_post_load,
+ .fields = (VMStateField []) {
+ VMSTATE_UINT64(clock, KVMClockState),
+ VMSTATE_END_OF_LIST()
+ }
+};
+
+static SysBusDeviceInfo kvmclock_info = {
+ .qdev.name = "kvmclock",
+ .qdev.size = sizeof(KVMClockState),
+ .qdev.vmsd = &kvmclock_vmsd,
+ .qdev.no_user = 1,
+ .init = kvmclock_init,
+};
+#endif /* KVM_CAP_ADJUST_CLOCK */
+
int kvm_arch_init_vcpu(CPUState *env)
{
struct {
@@ -335,7 +394,6 @@ int kvm_arch_init_vcpu(CPUState *env)
env->cpuid_svm_features &= kvm_x86_get_supported_cpuid(0x8000000A,
0, R_EDX);
-
cpuid_i = 0;
#ifdef CONFIG_KVM_PARA
@@ -442,6 +500,13 @@ int kvm_arch_init_vcpu(CPUState *env)
}
#endif
+#ifdef KVM_CAP_ADJUST_CLOCK
+ if (cpu_is_bsp(env) &&
+ (env->cpuid_kvm_features & (1ULL << KVM_FEATURE_CLOCKSOURCE))) {
+ sysbus_create_simple("kvmclock", -1, NULL);
+ }
+#endif
+
return kvm_vcpu_ioctl(env, KVM_SET_CPUID2, &cpuid_data);
}
@@ -534,6 +599,10 @@ int kvm_arch_init(int smp_cpus)
int ret;
struct utsname utsname;
+#ifdef KVM_CAP_ADJUST_CLOCK
+ sysbus_register_withprop(&kvmclock_info);
+#endif
+
ret = kvm_get_supported_msrs();
if (ret < 0) {
return ret;
--
1.7.1
next prev parent reply other threads:[~2011-01-03 8:33 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-03 8:32 [Qemu-devel] [PATCH v2 00/17] [uq/master] Prepare for more qemu-kvm merging Jan Kiszka
2011-01-03 8:32 ` [Qemu-devel] [PATCH v2 01/17] kvm: Fix coding style violations Jan Kiszka
2011-01-03 8:32 ` [Qemu-devel] [PATCH v2 02/17] kvm: Drop return value of kvm_cpu_exec Jan Kiszka
2011-01-03 8:32 ` [Qemu-devel] [PATCH v2 03/17] kvm: Stop on all fatal exit reasons Jan Kiszka
2011-01-03 8:32 ` [Qemu-devel] [PATCH v2 04/17] kvm: Improve reporting of fatal errors Jan Kiszka
2011-01-03 8:32 ` [Qemu-devel] [PATCH v2 05/17] x86: Optionally dump code bytes on cpu_dump_state Jan Kiszka
2011-01-03 13:13 ` [Qemu-devel] [PATCH v3 " Jan Kiszka
2011-01-03 8:32 ` [Qemu-devel] [PATCH v2 06/17] kvm: x86: Align kvm_arch_put_registers code with comment Jan Kiszka
2011-01-03 8:32 ` [Qemu-devel] [PATCH v2 07/17] kvm: x86: Prepare kvm_get_mp_state for in-kernel irqchip Jan Kiszka
2011-01-03 8:32 ` [Qemu-devel] [PATCH v2 08/17] kvm: x86: Remove redundant mp_state initialization Jan Kiszka
2011-01-03 8:32 ` [Qemu-devel] [PATCH v2 09/17] kvm: x86: Fix xcr0 reset mismerge Jan Kiszka
2011-01-03 8:33 ` [Qemu-devel] [PATCH v2 10/17] kvm: x86: Refactor msr_star/hsave_pa setup and checks Jan Kiszka
2011-01-03 8:33 ` [Qemu-devel] [PATCH v2 11/17] kvm: x86: Reset paravirtual MSRs Jan Kiszka
2011-01-03 16:40 ` [Qemu-devel] " Glauber Costa
2011-01-03 16:46 ` Jan Kiszka
2011-01-03 16:51 ` Glauber Costa
2011-01-03 8:33 ` [Qemu-devel] [PATCH v2 12/17] kvm: x86: Drop MCE MSRs write back restrictions Jan Kiszka
2011-01-03 8:33 ` [Qemu-devel] [PATCH v2 13/17] kvm: Eliminate KVMState arguments Jan Kiszka
2011-01-03 11:13 ` [Qemu-devel] " Alexander Graf
2011-01-03 8:33 ` Jan Kiszka [this message]
2011-01-03 16:04 ` [Qemu-devel] Re: [PATCH v2 14/17] kvm: x86: Introduce kvmclock device to save/restore its state Avi Kivity
2011-01-03 16:30 ` Jan Kiszka
2011-01-03 16:39 ` Glauber Costa
2011-01-03 16:41 ` Avi Kivity
2011-01-03 16:38 ` Glauber Costa
2011-01-03 16:37 ` Glauber Costa
2011-01-03 16:48 ` Jan Kiszka
2011-01-03 8:33 ` [Qemu-devel] [PATCH v2 15/17] kvm: Drop smp_cpus argument from init functions Jan Kiszka
2011-01-03 8:33 ` [Qemu-devel] [PATCH v2 16/17] kvm: x86: Rework identity map and TSS setup for larger BIOS sizes Jan Kiszka
2011-01-03 16:06 ` [Qemu-devel] " Avi Kivity
2011-01-03 16:52 ` Jan Kiszka
2011-01-03 16:59 ` Avi Kivity
2011-01-03 17:19 ` Jan Kiszka
2011-01-03 8:33 ` [Qemu-devel] [PATCH v2 17/17] kvm: Drop dependencies on very old capabilities Jan Kiszka
2011-01-03 16:08 ` [Qemu-devel] " Avi Kivity
2011-01-03 16:54 ` Jan Kiszka
2011-01-03 17:01 ` Avi Kivity
2011-01-03 17:24 ` Jan Kiszka
2011-01-03 12:44 ` [Qemu-devel] [PATCH 18/17] kvm: Flush coalesced mmio buffer on IO window exits Jan Kiszka
2011-01-03 16:09 ` [Qemu-devel] Re: [PATCH v2 00/17] [uq/master] Prepare for more qemu-kvm merging Avi Kivity
2011-01-04 8:42 ` Jan Kiszka
2011-01-04 9:02 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d35c17614fa7646ff48ef57f7922aec01e1044a6.1294043582.git.jan.kiszka@web.de \
--to=jan.kiszka@web.de \
--cc=avi@redhat.com \
--cc=glommer@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).